Merge pull request #9146 from tamasvajk/kotlin-inner-class-static

Kotlin: exclude Kotlin source from 'inner class could be static' check

Author: tamasvajk

java/ql/src/Performance/InnerClassCouldBeStatic.ql

@@ -130,7 +130,9 @@ predicate potentiallyStatic(InnerClass c) {
     )
   ) and
   // JUnit Nested test classes are required to be non-static.
-  not c.hasAnnotation("org.junit.jupiter.api", "Nested")
+  not c.hasAnnotation("org.junit.jupiter.api", "Nested") and
+  // There's no `static` in kotlin:
+  not c.getLocation().getFile().isKotlinSourceFile()
 }
 
 /**

java/ql/test/kotlin/query-tests/InnerClassCouldBeStatic/InnerClassCouldBeStatic.expected

@@ -0,0 +1 @@
+Performance/InnerClassCouldBeStatic.ql

java/ql/test/kotlin/query-tests/InnerClassCouldBeStatic/InnerClassCouldBeStatic.qlref

@@ -0,0 +1,6 @@
+class A {
+    fun fn1() {}
+    companion object {
+        fun fn2() {}
+    }
+}