Remove redundant exclusion of base Grape::API module from GrapeApiClass

felickz · felickz · commit 1bf6101967e8 · 2025-09-21T20:52:28.000-04:00
- should not impact extracted application code
diff --git a/ruby/ql/lib/codeql/ruby/frameworks/Grape.qll b/ruby/ql/lib/codeql/ruby/frameworks/Grape.qll
@@ -45,8 +45,7 @@ module Grape {
    */
   class GrapeApiClass extends DataFlow::ClassNode {
     GrapeApiClass() {
-      this = grapeApiBaseClass().getADescendentModule() and
-      not exists(DataFlow::ModuleNode m | m = grapeApiBaseClass().asModule() | this = m)
+      this = grapeApiBaseClass().getADescendentModule()
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -45,8 +45,7 @@ module Grape {`
`45`	`45`	`*/`
`46`	`46`	`class GrapeApiClass extends DataFlow::ClassNode {`
`47`	`47`	`GrapeApiClass() {`
`48`		`- this = grapeApiBaseClass().getADescendentModule() and`
`49`		`- not exists(DataFlow::ModuleNode m \| m = grapeApiBaseClass().asModule() \| this = m)`
	`48`	`+ this = grapeApiBaseClass().getADescendentModule()`
`50`	`49`	`}`
`51`	`50`
`52`	`51`	`/**`