Refactor RootApi class to use getAnImmediateDescendent for clarity

felickz · felickz · commit 50bf9ae7563e · 2025-09-21T20:44:46.000-04:00
diff --git a/ruby/ql/lib/codeql/ruby/frameworks/Grape.qll b/ruby/ql/lib/codeql/ruby/frameworks/Grape.qll
@@ -26,7 +26,7 @@ module Grape {
    */
   class RootApi extends GrapeApiClass {
     RootApi() {
-      not exists(GrapeApiClass parent | this != parent and this = parent.getADescendent())
+      not this = any(GrapeApiClass parent).getAnImmediateDescendent()
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ module Grape {`
`26`	`26`	`*/`
`27`	`27`	`class RootApi extends GrapeApiClass {`
`28`	`28`	`RootApi() {`
`29`		`- not exists(GrapeApiClass parent \| this != parent and this = parent.getADescendent())`
	`29`	`+ not this = any(GrapeApiClass parent).getAnImmediateDescendent()`
`30`	`30`	`}`
`31`	`31`	`}`
`32`	`32`