fix: issue with skipping bot pushes #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riley-kohler
force-pushed
the
fix-issue-with-skipping-bot-pushes
branch
from
49361ed to
fe7ac88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
This change fixes an issue that can arise with the logic to filter out bot pushes where automated pushes from other applications will not be synced. It is still necessary to filter out private mirrors pushes to avoid infinite looping with the sync back logic so a check was added to the syncReposHandler to see if the two branches' head shas already match.
Readiness Checklist
Author/Contributor
npm run lintand fix any linting issues that have been introducednpm run testand run tests@jeffrey-luszczReviewer
bug,documentation,enhancement,infrastructure,maintenance, orbreaking