Skip to content

fix(webhook): Fix publish events to EventBridge #5143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrecastro wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −6
Open

fix(webhook): Fix publish events to EventBridge #5143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9ec51a
fix(webhook): Fix publish events to EventBridge
andrecastro Jun 2, 2026
730f6eb
Read workflow_job event for logging enhancement
andrecastro Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions lambdas/functions/webhook/src/webhook/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export async function publishForRunners(

const checkBodySizeResult = checkBodySize(body, headers);

const { event, eventType } = readEvent(headers, body, ['workflow_job']);
const { event, eventType } = readWorkflowJobEvent(headers, body);
logger.info(`Github event ${event.action} accepted for ${event.repository.full_name}`);
if (checkBodySizeResult.sizeExceeded) {
// We only warn for large event, when moving the event bridge we can only can accept events up to 256KB
Expand All @@ -39,9 +39,16 @@ export async function publishOnEventBridge(

await verifySignature(headers, body, config.webhookSecret);

const checkBodySizeResult = checkBodySize(body, headers);
// Check for supported event types allowed to send to event bridge
const eventType = headers['x-github-event'] as string;
checkEventIsSupported(eventType, config.allowedEvents);
Comment thread
andrecastro marked this conversation as resolved.

const { eventType } = readEvent(headers, body, config.allowedEvents);
// If workflow_job event, read the event and log relevant information for monitoring and debugging purposes.
if (eventType === 'workflow_job') {
readWorkflowJobEvent(headers, body);
}

const checkBodySizeResult = checkBodySize(body, headers);

logger.info(
`Github event ${headers['x-github-event'] as string} accepted for ` +
Expand Down Expand Up @@ -126,13 +133,13 @@ function checkEventIsSupported(eventType: string, allowedEvents: string[]): void
}
}

function readEvent(
// Reads the workflow_job event from the request body and headers, and logs relevant information for monitoring and debugging purposes.
function readWorkflowJobEvent(
headers: IncomingHttpHeaders,
body: string,
allowedEvents: string[],
): { event: WorkflowJobEvent; eventType: string } {
const eventType = headers['x-github-event'] as string;
checkEventIsSupported(eventType, allowedEvents);
checkEventIsSupported(eventType, ['workflow_job']);

const event = JSON.parse(body) as WorkflowJobEvent;
logger.appendPersistentKeys({
Expand Down