Skip to content

fix(runner): handle long prefixes in pool scheduler and IAM resource names #5139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexjurkiewicz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(runner): handle long prefixes in pool scheduler and IAM resource names #5139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions modules/runners/pool/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
locals {
pool_name_prefix = (
length("${var.config.prefix}-pool") <= 38
? "${var.config.prefix}-pool"
: "${substr("${var.config.prefix}-pool", 0, 29)}-${substr(md5("${var.config.prefix}-pool"), 0, 8)}"
)
}

resource "aws_lambda_function" "pool" {

s3_bucket = var.config.lambda.s3_bucket != null ? var.config.lambda.s3_bucket : null
Expand Down Expand Up @@ -155,7 +163,7 @@ resource "aws_iam_role_policy" "pool_xray" {
}

resource "aws_scheduler_schedule_group" "pool" {
name_prefix = "${var.config.prefix}-pool"
name_prefix = local.pool_name_prefix

tags = var.config.tags
}
Expand Down Expand Up @@ -186,7 +194,7 @@ data "aws_iam_policy_document" "scheduler" {
}

resource "aws_iam_role" "scheduler" {
name_prefix = "${var.config.prefix}-pool"
name_prefix = local.pool_name_prefix

path = var.config.role_path
permissions_boundary = var.config.role_permissions_boundary
Expand Down
Loading