Skip to content

feat(publishOnEventBridge): add persistent keys in logs #5030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edersonbrilhante wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −6
Open

feat(publishOnEventBridge): add persistent keys in logs #5030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions lambdas/functions/webhook/src/webhook/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export async function publishForRunners(

const checkBodySizeResult = checkBodySize(body, headers);

const { event, eventType } = readEvent(headers, body);
const { event, eventType } = readEvent(headers, body, ['workflow_job']);
logger.info(`Github event ${event.action} accepted for ${event.repository.full_name}`);
if (checkBodySizeResult.sizeExceeded) {
// We only warn for large event, when moving the event bridge we can only can accept events up to 256KB
Expand All @@ -39,11 +39,10 @@ export async function publishOnEventBridge(

await verifySignature(headers, body, config.webhookSecret);

const eventType = headers['x-github-event'] as string;
checkEventIsSupported(eventType, config.allowedEvents);

const checkBodySizeResult = checkBodySize(body, headers);

const { eventType } = readEvent(headers, body, config.allowedEvents);

logger.info(
`Github event ${headers['x-github-event'] as string} accepted for ` +
`${headers['x-github-hook-installation-target-id'] as string}`,
Expand Down Expand Up @@ -127,9 +126,13 @@ function checkEventIsSupported(eventType: string, allowedEvents: string[]): void
}
}

function readEvent(headers: IncomingHttpHeaders, body: string): { event: WorkflowJobEvent; eventType: string } {
function readEvent(
headers: IncomingHttpHeaders,
body: string,
allowedEvents: string[],
): { event: WorkflowJobEvent; eventType: string } {
const eventType = headers['x-github-event'] as string;
checkEventIsSupported(eventType, ['workflow_job']);
checkEventIsSupported(eventType, allowedEvents);

const event = JSON.parse(body) as WorkflowJobEvent;
logger.appendPersistentKeys({
Expand Down
Loading