Pr/qmonnet/fix default src suggestions #1229
Merged
+89
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonnet
force-pushed
the
pr/qmonnet/fix-default-src-suggestions
branch
from
b6aec0f to
90ad5ef
Compare
Signed-off-by: Fredi Raspall <fredi@githedgehog.com> Signed-off-by: Quentin Monnet <qmo@qmon.net>
Include the fallback case in the lookup method of VpcConnectionsTable. We'll do the same for the lookup from the DstConnectionData object in a follow-up commit. Signed-off-by: Fredi Raspall <fredi@githedgehog.com> Signed-off-by: Quentin Monnet <qmo@qmon.net>
Wrapping the VPC discriminant for the "default" destination in a RemotePrefixPortData is not strictly necessary, but is more consistent with the rest of the code and with how we fall back to the default object for the checks on the source of the packet. This will also allow us to move the fallback to the DstConnectionData.lookup() method in a follow-up commit. Signed-off-by: Quentin Monnet <qmo@qmon.net>
Similar to what we did for the source lookup in a previous commit, move the fallback to the default destination data object to the DstConnectionData.lookup() method rather than the main lookup in the FlowFilterTable implementation. This makes the code clearer and more consistent. Signed-off-by: Quentin Monnet <qmo@qmon.net>
Replace format_packet_addrs_ports() by a Display implementation to avoid memory allocations per packet which occur in the original code even when the loglevel is not debug. The call to FlowTuple::new() could also be made within the debug!() but it is probably very cheap to call it per packet. Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Make sure we log intermediate lookup failures in the flow-filter lookup. Co-authored-by: Quentin Monnet <qmo@qmon.net> Signed-off-by: Fredi Raspall <fredi@githedgehog.com> Signed-off-by: Quentin Monnet <qmo@qmon.net>
Improve the Display implementation for types PrefixWithPorts and PrefixWithOptionalPorts. In particular, get rid of the "</>" used to represent the absence of specified port ranges for the latter type, and use the more explicit "[all]" instead to indicate it applies to all ports. Thanks to Fredi for the format suggestions. Signed-off-by: Quentin Monnet <qmo@qmon.net>
qmonnet
force-pushed
the
pr/qmonnet/fix-default-src-suggestions
branch
from
90ad5ef to
96a9b86
Compare
qmonnet
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targets #1227 (review)