fix time conversion #1226
Merged
fix time conversion #1226
+12
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fredi Raspall <fredi@githedgehog.com> Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
Fredi-raspall
changed the title
Fredi-raspall
force-pushed
the
pr/fredi-emanuele/fix_time_conversion
branch
from
8e3b4f5 to
3f6827b
Compare
Fixup the autogenerated rust types to use kube_core's Duration because it implements the deserialization from the format used in the CRDs. We want to continue using std::time::Duration in the internal types. So, use the existing From<> implementations wherever needed. Signed-off-by: Fredi Raspall <fredi@githedgehog.com> Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
Fredi-raspall
force-pushed
the
pr/fredi-emanuele/fix_time_conversion
branch
from
3f6827b to
5476998
Compare
qmonnet
requested changes
Jan 21, 2026
Member
qmonnet
left a comment
qmonnet
left a comment
There was a problem hiding this comment.
I didn't check what format the new type accepts, but I trust you did. The change looks good, can I only ask that we remove the previous dependency we used for this? See below
qmonnet
approved these changes
Jan 21, 2026
Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
Fredi-raspall
force-pushed
the
pr/fredi-emanuele/fix_time_conversion
branch
from
9aa13dd to
dd39377
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
Let's give it another try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/githedgehog/internal/issues/295