BMP Module initial implementation #1130
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeymatov
requested review from
Fredi-raspall
and removed request for
a team
sergeymatov
force-pushed
the
pr/smatov/bmp-frr-config
branch
from
43e8d27 to
6044efa
Compare
Fredi-raspall
requested changes
Dec 12, 2025
Contributor
Fredi-raspall
left a comment
Fredi-raspall
left a comment
There was a problem hiding this comment.
I like the approach and implementation!
I am going to request changes because I'd like to review this again once it is no longer a draft and some of the questions get clarified.
Thanks!
sergeymatov
force-pushed
the
pr/smatov/bmp-frr-config
branch
2 times, most recently
from
66e7168 to
613b990
Compare
sergeymatov
force-pushed
the
pr/smatov/bmp-frr-config
branch
2 times, most recently
from
4ce4148 to
eeea2b2
Compare
Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
sergeymatov
force-pushed
the
pr/smatov/bmp-frr-config
branch
2 times, most recently
from
7e1fe31 to
0727bd9
Compare
Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
sergeymatov
force-pushed
the
pr/smatov/bmp-frr-config
branch
2 times, most recently
from
f54a6b9 to
8978fb7
Compare
Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
sergeymatov
force-pushed
the
pr/smatov/bmp-frr-config
branch
2 times, most recently
from
309ef2e to
eac5056
Compare
Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
sergeymatov
force-pushed
the
pr/smatov/bmp-frr-config
branch
10 times, most recently
from
b7661e2 to
fc29919
Compare
Signed-off-by: Sergey Matov <sergey.matov@githedgehog.com>
sergeymatov
force-pushed
the
pr/smatov/bmp-frr-config
branch
from
fc29919 to
a2c14cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is WIP, desc will be added later