t1900: add tests for git repo structure subcommand #2066
Open
MansiSingh17 wants to merge 1 commit intogitgitgadget:masterfrom
Open
t1900: add tests for git repo structure subcommand #2066MansiSingh17 wants to merge 1 commit intogitgitgadget:masterfrom
MansiSingh17 wants to merge 1 commit intogitgitgadget:masterfrom
Conversation
|
There are merge commits in this Pull Request: Please rebase the branch and force-push. |
Author
|
/submit |
|
Error: Ignoring PR with empty title and/or body |
Author
|
/submit |
|
There are merge commits in this Pull Request: Please rebase the branch and force-push. |
39f96c6 to
cdb9fc4
Compare
Author
|
/submit |
|
Submitted as pull.2066.git.1773112159662.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
cdb9fc4 to
6cb0b52
Compare
|
Junio C Hamano wrote on the Git mailing list (how to reply to this email): "Mansi Singh via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Mansi Singh <mansimaanu8627@gmail.com>
>
> The t1900 test file covers git repo info thoroughly but has
> no tests for the git repo structure subcommand. Add basic
> tests to verify that:
>
> - git repo structure succeeds and produces no stderr output
> - git repo structure --format=keyvalue outputs expected keys
> - git repo structure --format=nul succeeds
> - git repo structure rejects an unknown format
Ask those who have worked on the relevant command to review by
adding them on the Cc: line.
|
The t1900 test file covers git repo info thoroughly but has no tests for the git repo structure subcommand. Add basic tests to verify that: - git repo structure succeeds and produces no stderr output - git repo structure --format=lines outputs expected keys - git repo structure --format=nul succeeds - git repo structure rejects an unknown format Signed-off-by: Mansi Singh <mansimaanu8627@gmail.com>
6cb0b52 to
0c6911b
Compare
Author
|
/submit |
|
K Jayatheerth wrote on the Git mailing list (how to reply to this email): > From: Mansi Singh <mansimaanu8627@gmail.com>
>
> The t1900 test file covers git repo info thoroughly but has
> no tests for the git repo structure subcommand. Add basic
> tests to verify that:
>
> - git repo structure succeeds and produces no stderr output
> - git repo structure --format=keyvalue outputs expected keys
> - git repo structure --format=nul succeeds
> - git repo structure rejects an unknown format
>
> Signed-off-by: Mansi Singh <mansimaanu8627@gmail.com>
> ---
> t1900: add tests for git repo structure subcommand
>
> Add tests for the git repo structure subcommand in t1900-repo-info.sh.
> The tests verify that git repo structure outputs the expected fields
> (commits, trees, blobs, tags) in both default and key-value formats.
>
> Signed-off-by: Mansi Singh mansimaanu8627@gmail.com
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2066%2FMansiSingh17%2Frepo-add-structure-tests-v3-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2066/MansiSingh17/repo-add-structure-tests-v3-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/2066
>
> t/t1900-repo-info.sh | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
Hi,
The very next file in t/
i.e t1901.. is about repo structure
You might wanna check that out
because I find most of these to be redundant
Regards
- Jayatheerth |
|
User |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC: Karthik Nayak karthik.188@gmail.com
CC: Justin Tobler jltobler@gmail.com
CC: Lucas Seiki Oshiro lucasseikioshiro@gmail.com
CC: Siddharth Asthana siddharthasthana31@gmail.com
cc: K Jayatheerth jayatheerthkulkarni2005@gmail.com