Skip to content

t1900: add tests for git repo structure subcommand #2066

Open
MansiSingh17 wants to merge 1 commit intogitgitgadget:masterfrom
MansiSingh17:repo-add-structure-tests-v3
Open

t1900: add tests for git repo structure subcommand #2066
MansiSingh17 wants to merge 1 commit intogitgitgadget:masterfrom
MansiSingh17:repo-add-structure-tests-v3

Conversation

@MansiSingh17
Copy link

@MansiSingh17 MansiSingh17 commented Mar 9, 2026

CC: Karthik Nayak karthik.188@gmail.com
CC: Justin Tobler jltobler@gmail.com
CC: Lucas Seiki Oshiro lucasseikioshiro@gmail.com
CC: Siddharth Asthana siddharthasthana31@gmail.com
cc: K Jayatheerth jayatheerthkulkarni2005@gmail.com

@gitgitgadget
Copy link

gitgitgadget bot commented Mar 9, 2026

There are merge commits in this Pull Request:

394c18092f3e2a773333a08d3f8241322a97aa39
db227bce2224b55b11954a5f292a0b035b7d9279
d93be9cbcaf80f4d1ff56a3d7aa5d722236b6eac

Please rebase the branch and force-push.

@MansiSingh17
Copy link
Author

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Mar 9, 2026

Error: Ignoring PR with empty title and/or body

@MansiSingh17 MansiSingh17 changed the title t1900: add tests for git repo structure subcommand t1900: add tests for git repo structure subcommand Mar 9, 2026
@MansiSingh17
Copy link
Author

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Mar 9, 2026

There are merge commits in this Pull Request:

394c18092f3e2a773333a08d3f8241322a97aa39
db227bce2224b55b11954a5f292a0b035b7d9279
d93be9cbcaf80f4d1ff56a3d7aa5d722236b6eac

Please rebase the branch and force-push.

@MansiSingh17 MansiSingh17 force-pushed the repo-add-structure-tests-v3 branch from 39f96c6 to cdb9fc4 Compare March 10, 2026 02:27
@MansiSingh17
Copy link
Author

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Mar 10, 2026

Submitted as pull.2066.git.1773112159662.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-2066/MansiSingh17/repo-add-structure-tests-v3-v1

To fetch this version to local tag pr-2066/MansiSingh17/repo-add-structure-tests-v3-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-2066/MansiSingh17/repo-add-structure-tests-v3-v1

@MansiSingh17 MansiSingh17 force-pushed the repo-add-structure-tests-v3 branch from cdb9fc4 to 6cb0b52 Compare March 10, 2026 03:41
@gitgitgadget
Copy link

gitgitgadget bot commented Mar 10, 2026

Junio C Hamano wrote on the Git mailing list (how to reply to this email):

"Mansi Singh via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Mansi Singh <mansimaanu8627@gmail.com>
>
> The t1900 test file covers git repo info thoroughly but has
> no tests for the git repo structure subcommand. Add basic
> tests to verify that:
>
> - git repo structure succeeds and produces no stderr output
> - git repo structure --format=keyvalue outputs expected keys
> - git repo structure --format=nul succeeds
> - git repo structure rejects an unknown format

Ask those who have worked on the relevant command to review by
adding them on the Cc: line.

The t1900 test file covers git repo info thoroughly but has
no tests for the git repo structure subcommand. Add basic
tests to verify that:

- git repo structure succeeds and produces no stderr output
- git repo structure --format=lines outputs expected keys
- git repo structure --format=nul succeeds
- git repo structure rejects an unknown format

Signed-off-by: Mansi Singh <mansimaanu8627@gmail.com>
@MansiSingh17 MansiSingh17 force-pushed the repo-add-structure-tests-v3 branch from 6cb0b52 to 0c6911b Compare March 10, 2026 05:31
@MansiSingh17
Copy link
Author

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Mar 10, 2026

K Jayatheerth wrote on the Git mailing list (how to reply to this email):

> From: Mansi Singh <mansimaanu8627@gmail.com>
> 
> The t1900 test file covers git repo info thoroughly but has
> no tests for the git repo structure subcommand. Add basic
> tests to verify that:
> 
> - git repo structure succeeds and produces no stderr output
> - git repo structure --format=keyvalue outputs expected keys
> - git repo structure --format=nul succeeds
> - git repo structure rejects an unknown format
> 
> Signed-off-by: Mansi Singh <mansimaanu8627@gmail.com>
> ---
>     t1900: add tests for git repo structure subcommand
> 
>     Add tests for the git repo structure subcommand in t1900-repo-info.sh.
>     The tests verify that git repo structure outputs the expected fields
>     (commits, trees, blobs, tags) in both default and key-value formats.
> 
>     Signed-off-by: Mansi Singh mansimaanu8627@gmail.com
> 
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2066%2FMansiSingh17%2Frepo-add-structure-tests-v3-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2066/MansiSingh17/repo-add-structure-tests-v3-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/2066
> 
>  t/t1900-repo-info.sh | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 


Hi,

The very next file in t/
i.e t1901.. is about repo structure

You might wanna check that out
because I find most of these to be redundant

Regards
- Jayatheerth

@gitgitgadget
Copy link

gitgitgadget bot commented Mar 10, 2026

User K Jayatheerth <jayatheerthkulkarni2005@gmail.com> has been added to the cc: list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant