Open
Conversation
Automatically pin to that version
This is done to be extra sure that our behavior really works as expected because there are many cases where this could break
Use the version explicitly to get the necessary versions
This allows us to skip over using the Github API which can hit the rate limit. We also introduce a cache to avoid the Git server's rate limit
woojiahao
force-pushed
the
woojiahao/version-pinning
branch
from
02ca031 to
ac2c392
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per RFC: https://docs.google.com/document/d/1MUoQ_Zgk5OKdM4N0AjjUo1OJcYpWvdyCOZa4j13X31I/edit?usp=sharing