Fix scope regex pattern and exit NameError#48
Open
desmondwong1215 wants to merge 2 commits intogit-mastery:mainfrom
Open
Fix scope regex pattern and exit NameError#48desmondwong1215 wants to merge 2 commits intogit-mastery:mainfrom
exit NameError#48desmondwong1215 wants to merge 2 commits intogit-mastery:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, this regex pattern only matches scopes that are wrapped in single quotes. But there are no single quotes in the older version.
I have modified the regex pattern to make it more flexible, allowing us to parse the scope correctly for all versions.
'NameError' is raised when the process is terminated due to errors.
exit()built-in is only available in interactive Python sessions, not in scripts.I have changed
exit()to' sys.exit()`, so that the process will be terminated more cleanly.