fix(config): avoid config duplications#2345
Draft
becm wants to merge 2 commits into
Draft
Conversation
Contributor
|
@becm Thanks for identifying this key piece that connects to several issues. Could you add a test to demonstrate the behavior change to prevent regressions in the future? |
Contributor
Author
|
@derrickstolee sadly only the 1st step, since:
|
add parameter to make file include behavior in config read consistent retain existing parameters on write, always uses "primary" scope file
find last guard entry and verify location is in front current executable skip addition of guard entry if already present
Contributor
Author
|
@derrickstolee since the Will try to implement a test for (abstract) config data with the (hopefully) resolved corner case of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid duplication of entries already present in included files:
Improves consistency regarding include behavior with cached Git config and
Fixes #2342
Fixes #1696
Fixes #1337