Fix #67: Commit parent outside scope#117
Merged
peso merged 4 commits intogit-bahn:masterfrom Nov 2, 2025
Merged
Conversation
mlange-42
reviewed
Sep 22, 2025
peso
force-pushed
the
parent-outside-scope
branch
from
8177cee to
2854513
Compare
By using Rust a little differently the amount of curtains can be reduced.
Move code out of deeply nested function
Move code out of deeply nested function
peso
force-pushed
the
parent-outside-scope
branch
from
2854513 to
9cbc060
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the parent-outside-scope issue, I did some cleanup.
Some of the changes may look a little odd, but they prepare a PR on octo-merge. By isolating the code that will change to a separate line, the rebase operations in separating them became easier. My development process is more chaotic than I want my PRs to be.