Feat/git config native#407
Merged
svarlamov merged 11 commits intogit-ai-project:mainfrom Jan 28, 2026
Merged
Conversation
add tests to native git config implementation
svarlamov
requested changes
Jan 27, 2026
Member
svarlamov
left a comment
There was a problem hiding this comment.
Thanks for the PR had a few thoughts:
git configworks even outside of a repo. I noticed that you're passing a filepath into the repo -- what if the user is outside of a repo? Will this still work?- Please use the existing TestRepo harness instead of creating another utility for test repos for the unit tests. You can reference the existing unit tests in the codebase to see how to use TestRepo
- Noticed the tests use the serial macro. We try to avoid using it if at all possible -- with TestRepo maybe we could avoid it?
Contributor
Author
|
Hey @svarlamov ,
|
Contributor
Author
|
about current git config implementation:
|
svarlamov
approved these changes
Jan 28, 2026
Member
svarlamov
left a comment
There was a problem hiding this comment.
LGTM! I added some tests for bare clones, etc. but it was pretty complete. Thanks!
Contributor
Author
I see what you did to test global config fallback, modifying the global config directly also works, nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #376
git configcommands invocations with gix-config native Rust implementationGixErrortypegit configcommands