Feat/reading graph #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flecart
reviewed
Jan 21, 2023
Comment on lines
-279
to
282
|
|
||
| impl<T> Into<Graph> for DFA<T> { | ||
| fn into(self) -> Graph { | ||
| impl<T> IntoGraph for DFA<T> { | ||
| fn into_graph(&self) -> Graph { | ||
| let mut graph = Graph::new(); |
Collaborator
There was a problem hiding this comment.
In rust ci sono dei trait From e Into che sono builtin, non sarebbe meglio utilizzare quelli?
https://doc.rust-lang.org/std/convert/trait.From.html
Poi se implementi from hai già into. Però alla fine è solo questione di stile quindi come vuoi 🤷♂️
Owner
Author
There was a problem hiding this comment.
Into non puoi passare l'oggetto come reference
Collaborator
There was a problem hiding this comment.
Puoi, ti basta implementare Into<&Graph>.
| let nfa = NFA::from(®ex); | ||
| println!("{:?}", nfa); | ||
| let out = serde_json::to_string(&nfa); | ||
| panic!("{:?}\n", out.unwrap()); |
Collaborator
There was a problem hiding this comment.
questo test utile per debuggare, però dovresti fixarlo.
|
|
||
| use super::NFA; | ||
|
|
||
| //TODO rifare tutto con strade |
Collaborator
There was a problem hiding this comment.
è ancora utile questo commento?
| move |input| tuple((multispace0, tag(label), multispace0, tag(":"), multispace0))(input) | ||
| } | ||
|
|
||
| fn read_start_stete(input: &str) -> IResult<&str, usize> { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.