Skip to content

SDK-2756: Revert ability to request share codes as part of a regular … #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrBurtyyy merged 1 commit into from
Feb 16, 2026
Merged

SDK-2756: Revert ability to request share codes as part of a regular … #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 0 additions & 68 deletions ...k-api/src/main/java/com/yoti/api/client/docs/session/create/RequiredShareCodePayload.java
View file
Open in desktop

This file was deleted.

32 changes: 2 additions & 30 deletions yoti-sdk-api/src/main/java/com/yoti/api/client/docs/session/create/SessionSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ public class SessionSpec {
@JsonProperty("create_identity_profile_preview")
private final Boolean createIdentityProfilePreview;

@JsonProperty("required_share_codes")
private final List<RequiredShareCodePayload> requiredShareCodes;

private SessionSpec(Integer clientSessionTokenTtl,
Integer resourcesTtl,
ImportTokenPayload importToken,
Expand All @@ -88,8 +85,7 @@ private SessionSpec(Integer clientSessionTokenTtl,
SubjectPayload subject,
ResourceCreationContainer resources,
Boolean createIdentityProfilePreview,
AdvancedIdentityProfileRequirementsPayload advancedIdentityProfileRequirements,
List<RequiredShareCodePayload> requiredShareCodes) {
AdvancedIdentityProfileRequirementsPayload advancedIdentityProfileRequirements) {
this.clientSessionTokenTtl = clientSessionTokenTtl;
this.resourcesTtl = resourcesTtl;
this.importToken = importToken;
Expand All @@ -107,7 +103,6 @@ private SessionSpec(Integer clientSessionTokenTtl,
this.resources = resources;
this.createIdentityProfilePreview = createIdentityProfilePreview;
this.advancedIdentityProfileRequirements = advancedIdentityProfileRequirements;
this.requiredShareCodes = requiredShareCodes;
}

public static Builder builder() {
Expand Down Expand Up @@ -268,15 +263,6 @@ public AdvancedIdentityProfileRequirementsPayload getAdvancedIdentityProfileRequ
return advancedIdentityProfileRequirements;
}

/**
* The list of Share Codes being requested.
*
* @return the requested Share Codes
*/
public List<RequiredShareCodePayload> getRequiredShareCodes() {
return requiredShareCodes;
}

public static class Builder {

private final List<RequestedCheck<?>> requestedChecks;
Expand All @@ -296,13 +282,11 @@ public static class Builder {
private SubjectPayload subject;
private ResourceCreationContainer resources;
private Boolean createIdentityProfilePreview;
private final List<RequiredShareCodePayload> requiredShareCodes;

private Builder() {
requestedChecks = new ArrayList<>();
requestedTasks = new ArrayList<>();
requiredDocuments = new ArrayList<>();
requiredShareCodes = new ArrayList<>();
}

/**
Expand Down Expand Up @@ -493,17 +477,6 @@ public Builder withAdvancedIdentityProfileRequirements(AdvancedIdentityProfileRe
return this;
}

/**
* Adds a required Share Code to the list
*
* @param requiredShareCode the required share code
* @return the builder
*/
public Builder withRequiredShareCode(RequiredShareCodePayload requiredShareCode) {
this.requiredShareCodes.add(requiredShareCode);
return this;
}

/**
* Builds the {@link SessionSpec} based on the values supplied to the builder
*
Expand All @@ -527,8 +500,7 @@ public SessionSpec build() {
subject,
resources,
createIdentityProfilePreview,
advancedIdentityProfileRequirementsPayload,
requiredShareCodes);
advancedIdentityProfileRequirementsPayload);
}
}

Expand Down
38 changes: 0 additions & 38 deletions yoti-sdk-api/src/test/java/com/yoti/api/client/docs/session/create/SessionSpecTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@ public class SessionSpecTest {
private static final String SOME_SDK_CONFIG_LOCALE = "en";
private static final String SOME_SDK_CONFIG_PRESET_ISSUING_COUNTRY = "USA";

private static final String SOME_ISSUER = "UK_GOV";
private static final String SOME_SCHEME = "RTW";
private static final String SOME_OTHER_ISSUER = "someOtherIssuer";
private static final String SOME_OTHER_SCHEME = "someOtherScheme";

private static final String SOME_SDK_CONFIG_SUCCESS_URL = "https://yourdomain.com/some/success/endpoint";
private static final String SOME_SDK_CONFIG_ERROR_URL = "https://yourdomain.com/some/error/endpoint";

Expand Down Expand Up @@ -257,37 +252,4 @@ public void shouldBuildWithImportToken() {
assertThat(sessionSpec.getImportToken(), is(importTokenMock));
}

@Test
public void shouldBuildWithSingleRequiredShareCode() {
RequiredShareCodePayload requiredShareCodePayload = RequiredShareCodePayload.builder()
.withIssuer(SOME_ISSUER)
.withScheme(SOME_SCHEME)
.build();

SessionSpec sessionSpec = SessionSpec.builder()
.withRequiredShareCode(requiredShareCodePayload)
.build();

assertThat(sessionSpec.getRequiredShareCodes(), containsInRelativeOrder(requiredShareCodePayload));
}

@Test
public void shouldBuildWithMultipleRequiredShareCodes() {
RequiredShareCodePayload requiredShareCodePayload1 = RequiredShareCodePayload.builder()
.withIssuer(SOME_ISSUER)
.withScheme(SOME_SCHEME)
.build();
RequiredShareCodePayload requiredShareCodePayload2 = RequiredShareCodePayload.builder()
.withIssuer(SOME_OTHER_ISSUER)
.withScheme(SOME_OTHER_SCHEME)
.build();

SessionSpec sessionSpec = SessionSpec.builder()
.withRequiredShareCode(requiredShareCodePayload1)
.withRequiredShareCode(requiredShareCodePayload2)
.build();

assertThat(sessionSpec.getRequiredShareCodes(), containsInRelativeOrder(requiredShareCodePayload1, requiredShareCodePayload2));
}

}