Skip to content

Update disks.md (EFI partition size)#644

Merged
EbonJaeger merged 6 commits intogetsolus:masterfrom
sebo505:patch-1
Apr 18, 2026
Merged

Update disks.md (EFI partition size)#644
EbonJaeger merged 6 commits intogetsolus:masterfrom
sebo505:patch-1

Conversation

@sebo505
Copy link
Copy Markdown
Contributor

@sebo505 sebo505 commented Jul 2, 2025

change 1 GB EFI partition size recommendation to 1 GiB (= 1024 MiB) as is Calamares requirement

Description

This pull request modifies disks.md to adjust Efi size recommendation from 1 GB to 1 GiB (= 1024 MiB) to comply with Calamares requirements.

This solves #643

change 1 GB EFI partition size recommendation to 1 GiB (= 1024 MiB) as is Calamares requirement
@Staudey
Copy link
Copy Markdown
Member

Staudey commented Jul 2, 2025

There is also one more reference here:

- On UEFI systems, an EFI partition of 1 GB minimum

Comment thread docs/user/quick-start/installation/disks.md Outdated
Comment thread docs/user/quick-start/installation/disks.md Outdated
@TraceyC77
Copy link
Copy Markdown
Contributor

@sebo505 if you're still interested in this, the changes needed are pretty small. This would be valuable to us :)

@sebo505
Copy link
Copy Markdown
Contributor Author

sebo505 commented Oct 25, 2025

if you're still interested in this, the changes needed are pretty small. This would be valuable to us :)

The reason why this issue had stalled is a skill issue on my side. This is the first pull request I had ever opened, then someone had proposed changes, and I then didn't know how to incorporate them or perform changes on the suggested changes.

@malfisya
Copy link
Copy Markdown
Member

@sebo505 I added a few commits to address the reviews. I opted to only show MiB on disks.md (as @deoxys94 suggest). I opted not to remove the line from system-requirements.md (as @Staudey suggested), instead change it to GiB and add link to disks.md

Copy link
Copy Markdown
Member

@Staudey Staudey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion based on recent changes to calamares, otherwise LGTM

Comment thread docs/user/quick-start/installation/disks.md Outdated
Comment thread docs/user/quick-start/installation/system-requirements.md Outdated
Copy link
Copy Markdown
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-project-automation github-project-automation Bot moved this from Backlog to Approved in Web and Documentation Apr 18, 2026
@EbonJaeger EbonJaeger merged commit d6a7521 into getsolus:master Apr 18, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Approved to Completed in Web and Documentation Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Completed

Development

Successfully merging this pull request may close these issues.

6 participants