Update disks.md (EFI partition size)#644
Merged
EbonJaeger merged 6 commits intogetsolus:masterfrom Apr 18, 2026
Merged
Conversation
change 1 GB EFI partition size recommendation to 1 GiB (= 1024 MiB) as is Calamares requirement
Member
|
There is also one more reference here: |
Staudey
reviewed
Jul 2, 2025
Contributor
|
@sebo505 if you're still interested in this, the changes needed are pretty small. This would be valuable to us :) |
Contributor
Author
The reason why this issue had stalled is a skill issue on my side. This is the first pull request I had ever opened, then someone had proposed changes, and I then didn't know how to incorporate them or perform changes on the suggested changes. |
Member
Staudey
reviewed
Feb 21, 2026
Member
Staudey
left a comment
There was a problem hiding this comment.
Just a suggestion based on recent changes to calamares, otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change 1 GB EFI partition size recommendation to 1 GiB (= 1024 MiB) as is Calamares requirement
Description
This pull request modifies disks.md to adjust Efi size recommendation from
1 GBto1 GiB (= 1024 MiB)to comply with Calamares requirements.This solves #643