feat(taskbroker): Add Migration Flag and Pipeline Stage#673
Open
george-sentry wants to merge 4 commits into
Open
feat(taskbroker): Add Migration Flag and Pipeline Stage#673george-sentry wants to merge 4 commits into
george-sentry wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 714044c. Configure here.
…eorge/push-taskbroker/migrate-on-deploy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Linear
Refs STREAM-1088
Description
We need to perform migrations with a sufficiently privileged user, and we don't want taskbrokers stumbling over each other to perform migrations every time they restart. Instead, we can perform migrations and create all necessary databases during deployment one time.
Changes...
--run/-rargument that either runs thebroker(default) ormigrationspg_ddl_usernameandpg_ddl_passwordconfig fields for the user that will perform migrations--run=migrations, it creates the necessary database if it doesn't already exist, runssqlx::migrate!, and exits