feat(gcs): Log payload, token, and request timing for GCS writes#289
Merged
feat(gcs): Log payload, token, and request timing for GCS writes#289
Conversation
Record elapsed milliseconds for pybytes_to_bytes, GCP token retrieval (provider init and token fetch), and the HTTP upload send, and include them on the successful-write info log for easier latency diagnosis. Co-Authored-By: Cursor <noreply@cursor.com> Made-with: Cursor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧Deps
🤖 This preview updates automatically when you update the PR. |
evanh
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add millisecond timings to the GCS writer success log for three stages:
extracting payload bytes from the Python message (
pybytes_to_bytes),obtaining a GCP access token (including lazy provider init on first use),
and sending the upload HTTP request.
This makes it easier to see where time is spent when diagnosing slow GCS
writes without adding separate metrics or tracing spans.
Made with Cursor