Skip to content

chore(deps): put honcho into non-development dependencies group#7579

Closed
aldy505 wants to merge 1 commit intogetsentry:masterfrom
aldy505:chore/honcho-prod-deps
Closed

chore(deps): put honcho into non-development dependencies group#7579
aldy505 wants to merge 1 commit intogetsentry:masterfrom
aldy505:chore/honcho-prod-deps

Conversation

@aldy505
Copy link
Copy Markdown
Collaborator

@aldy505 aldy505 commented Dec 5, 2025

@aldy505 aldy505 requested a review from a team as a code owner December 5, 2025 14:10
@joshuarli
Copy link
Copy Markdown
Member

It's not a production dependency though. devserver is run by devs

@aldy505
Copy link
Copy Markdown
Collaborator Author

aldy505 commented Dec 5, 2025

It's not a production dependency though. devserver is run by devs

@joshuarli it doesn't matter if it's being run on production or not, the problem lays here on this block:

snuba/Dockerfile

Lines 164 to 182 in 27da82f

FROM application_base AS testing
USER 0
COPY ./rust_snuba/ ./rust_snuba/
# re-"install" rust for the testing image
COPY --from=build_rust_snuba /root/.cargo/ /root/.cargo/
COPY --from=build_rust_snuba /root/.rustup/ /root/.rustup/
COPY --from=build_rust_snuba /usr/src/snuba/rust_snuba/target/wheels/ /tmp/rust_wheels/
RUN set -ex; \
# we need to resync, this time with dev dependencies
uv sync --frozen --no-install-package rust_snuba; \
# this will uninstall the rust wheel so we need to reinstall again
uv pip install /tmp/rust_wheels/*; \
rm -rf /tmp/rust_wheels/; \
snuba --help
ENV PATH="${PATH}:/root/.cargo/bin/"
USER snuba

To run devserver, the only dependency you need from the dev dependency group is just honcho, nothing else.

@hubertdeng123
Copy link
Copy Markdown
Member

Sentry's CI uses honcho to run the devserver. Should sentry CI be using the snuba devserver in CI? That's a question for @getsentry/owners-snuba and then we can figure out how to proceed from there

@phacops
Copy link
Copy Markdown
Contributor

phacops commented Jan 12, 2026

We likely do this to spin up the API + consumers + run migrations all at once, which is useful for CI.

@phacops
Copy link
Copy Markdown
Contributor

phacops commented Jan 26, 2026

We need to rethink how our Docker images are built in order to slim them down for self-hosted but putting a dev only dependency into our production dependencies is not going to do it.

@phacops phacops closed this Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants