Skip to content

feat(consumers): Send logs for tracing events at or above INFO#7250

Merged
phacops merged 17 commits intomasterfrom
lcian/feat/add-logs
Jan 8, 2026
Merged

feat(consumers): Send logs for tracing events at or above INFO#7250
phacops merged 17 commits intomasterfrom
lcian/feat/add-logs

Conversation

@lcian
Copy link
Copy Markdown
Member

@lcian lcian commented Jun 25, 2025 •
edited
Loading

Hello 👋
As the tracing integration now supports sending logs, this PR enables them as we're doing in our other Rust-based services. Feel free to close this if you don't intend to use logs.

Changes:

  • Bump the SDK to the latest version
  • Bump arroyo to the latest version to avoid an SDK version split
  • Disable the release-health feature flag, as that would add unnecessary dependencies
  • Send everything at or above INFO as logs instead of breadcrumbs (default for our tracing layer)

@lcian lcian requested a review from a team as a code owner June 25, 2025 07:49
lcian
lcian commented Jun 25, 2025
View reviewed changes
Comment thread rust_snuba/rust-toolchain.toml
@untitaker
Copy link
Copy Markdown
Member

untitaker commented Jun 25, 2025

you can disable the sentry feature of statsdproxy to resolve the version conflict. since DDM is dead that feature doesn't make any sense anymore.

@untitaker
Copy link
Copy Markdown
Member

untitaker commented Jun 25, 2025

actually can you bump statsdproxy crate as well? the sentry feature has been gone for quite a while there

@lcian
Copy link
Copy Markdown
Member Author

lcian commented Jun 25, 2025

actually can you bump statsdproxy crate as well? the sentry feature has been gone for quite a while there

Sure, I'll split this into two PRs

@lcian lcian marked this pull request as draft June 25, 2025 11:16
@lcian lcian mentioned this pull request Jun 25, 2025
Merged
@lcian lcian force-pushed the lcian/feat/add-logs branch from 8fb3288 to 0d25a12 Compare June 25, 2025 12:59
@lcian lcian changed the base branch from master to lcian/bump-rust-toolchain June 25, 2025 13:00
lcian
lcian commented Jun 25, 2025
View reviewed changes
Comment thread rust_snuba/Cargo.lock Outdated
@lcian lcian mentioned this pull request Jun 25, 2025
Merged
kylemumma pushed a commit that referenced this pull request Jul 2, 2025
@lcian
chore(consumers): Bump Rust toolchain version (#7252)
25bd694 
Bumps the Rust toolchain version to the latest stable. Bumping to >=1.85
is one of the solutions to proceed with
#7250

Also fixes the new lints.
Base automatically changed from lcian/bump-rust-toolchain to master July 2, 2025 17:01
@lcian lcian marked this pull request as ready for review July 7, 2025 11:57
@lcian lcian requested a review from untitaker July 7, 2025 11:58
@phacops phacops merged commit a319040 into master Jan 8, 2026
34 checks passed
@phacops phacops deleted the lcian/feat/add-logs branch January 8, 2026 23:23
@github-actions github-actions Bot mentioned this pull request Jan 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phacops phacops phacops approved these changes

@untitaker untitaker untitaker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lcian @untitaker @phacops