feat(auth): Pull in sentry-google-auth #11769
Conversation
dcramer
commented
Jan 29, 2019
dcramer
commented
- renames app from sentry_auth_google to google
- adds support for options-based configuration
|
The options-based configuration is based on getsentry/sentry-auth-google#19 |
|
Identified a couple weak spots I'm addressing related to options |
dcramer
force-pushed
the
feat/vendor-google-auth
branch
3 times, most recently
from
6f2dbf1 to
a2e5664
Compare
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
Looks good to me, but I'm not at all familiar with the google oauth2 plugin.
| @@ -0,0 +1,3 @@ | |||
| <h3>Domain</h3> | |||
There was a problem hiding this comment.
Would be nice to see this template live with other templates, but this is fine 🤷♂️
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
imo something we can follow up on - theres improvements we need to make to SSO for onpremise at some point anyways
|
also need to merge this in combination with removing sentry-auth-google from getsentry |
dcramer
force-pushed
the
feat/vendor-google-auth
branch
from
a2e5664 to
0adf014
Compare
|
Gonna try to merge this today. After merged, we need to land https://github.com/getsentry/getsentry/pull/2578 before deploy. |
- renames app from sentry_auth_google to google - adds support for options-based configuration
dcramer
force-pushed
the
feat/vendor-google-auth
branch
from
0adf014 to
aa8eaf2
Compare
