Conversation
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
54d6731 to
3844b1d
Compare
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Another
ref(⚡️)speedup—this time removingstylelintentirelyWe've gone back and forth on having
stylelintin the codebase. It was removed in June 2024 (biome added) and added back in November 2024 (biome removed). In the 68k+ commits between then and now, stylelint has detected zero meaningful violations.pre-commitrunsstylelintwith--quietwhich suppresses warnings entirelystylelintCSS-in-JS support isn't great—the maintenance cost here has been us trying to get the two to play nicelystylelint-disablecomments were all false-positives, not real issues@sentry/scrapslint rules enforce semantic token usage and general design system adherence across JS and CSS-in-JS which is a better enforcement mechanismResults
Ran
hyperfineagainst a few different configurations ofpnpm lintto understand the performance win here.pnpm run lint:css(stylelint only)pnpm run linton master (eslint + stylelint)pnpm run linton branch (eslint only)stylelintremoval makespnpm run lint1.57x faster, saving ~52 seconds.