Conversation
…ifts Wrap the OverlayTrigger.Button in each filter selector with a Container capped at 300px max-width. This prevents the trigger from expanding when a long filter value is selected, eliminating the layout shift in the filters bar. A shared FILTER_SELECTOR_MAX_WIDTH constant is exported from filterSelector.tsx and imported by numericFilterSelector.tsx so the cap stays in sync across both selector types. Fixes DAIN-1377 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
…n-long-filter-name-used
DominikB2014
approved these changes
Mar 23, 2026
gggritso
deleted the
georgegritsouk/dain-1377-layout-shifts-when-long-filter-name-used
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps each filter selector trigger in a
Containerwith amaxWidthof300pxso that selecting a long filter value doesn't cause the trigger button to expand and push other elements around in the filters bar as much. It still will a bit!Fixes DAIN-1377