Conversation
github-actions
bot
added
the
Scope: Frontend
| <Tooltip | ||
| title={dashboard.title} | ||
| position="top" | ||
| showOnlyOnOverflow | ||
| skipWrapper | ||
| > | ||
| <Text ellipsis variant="inherit"> | ||
| {dashboard.title} | ||
| </Text> | ||
| </Tooltip> |
There was a problem hiding this comment.
This was identical in the 3 places that use the reorderable links, so I built it into the component
… MDX MDX files are parsed by acorn which doesn't support TypeScript syntax. Removing the type annotations from the function signature fixes the lint and knip parse errors. Co-Authored-By: Claude Sonnet 4 <noreply@example.com>
Add explicit type annotations to MockPrimaryNav, ActivePrimaryLink, WithPageFrame, and MockSecondaryNav to resolve MDX typecheck errors. Co-Authored-By: Claude <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Mirror the style pattern from SecondaryNavigationListItem by adding listStyleType: 'none' to prevent default bullet markers from appearing on reorderable list items rendered as <li> elements. Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Add JSDoc type annotations to the four exported helper functions so that typecheck:mdx passes without implicit-any or type mismatch errors. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@cursoragent add maxHeight={undefined} to the <Storybook.Demo> components used here |
|
I've successfully added The changes have been committed and pushed to the PR:
  |
Set maxHeight={undefined} on Storybook.Demo components to allow
navigation demos to display at their natural height.
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
There was a problem hiding this comment.
Thoughts on hoisting this into @sentry/scraps? I'd love to be able to have stories re-use the secondary nav component.
Guess it's not that decoupled yet, disregard!
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
3 participants
Add stories for primary and secondary navigation so that we can have an overview of all the components in a single place + an easy way to toggle the page-frame view