docs: Remove extras from installation instructions#107492
Conversation
sentrivana
changed the title
github-actions
Bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
|
Generally makes sense - but I think you can simplify even more here: the utility functions that generate the OnboardingConfigs like |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| packageName = 'sentry-sdk[litellm]'; | ||
| } else if (selected === 'google_genai') { | ||
| packageName = 'sentry-sdk[google_genai]'; | ||
| } else if (selected === 'pydantic_ai') { |
There was a problem hiding this comment.
Agent monitoring install missing integration-specific packages
Medium Severity
The install function was changed to ignore the params argument entirely and now calls getPythonInstallCodeBlock() without any parameters. Previously, the code checked the selected integration (langchain, langgraph, litellm, google_genai, pydantic_ai) and included the corresponding package. Users following these instructions for integrations like LangChain won't be told to install the required packages (e.g., langchain), and the integration won't work without them.
| text: t('Install the Sentry SDK.'), | ||
| }, | ||
| getPythonInstallCodeBlock({packageName}), | ||
| getPythonInstallCodeBlock(), |
There was a problem hiding this comment.
Feature flag install missing provider-specific packages
Medium Severity
The packageName property was removed from FEATURE_FLAG_CONFIGURATION_MAP entries, and getPythonInstallCodeBlock() is now called without any parameters. This means users configuring LaunchDarkly, OpenFeature, Statsig, or Unleash integrations won't be told to install the required packages. The configuration code examples import these packages (e.g., ldclient, openfeature), but the install step doesn't tell users to install them.
| content: [ | ||
| { | ||
| type: 'text', | ||
| text: | ||
| featureFlagOptions.integration === FeatureFlagProviderEnum.GENERIC | ||
| ? t('Install the Sentry SDK.') | ||
| : t('Install the Sentry SDK with an extra.'), | ||
| text: t('Install the Sentry SDK.'), | ||
| }, | ||
| getPythonInstallCodeBlock({packageName}), | ||
| getPythonInstallCodeBlock(), | ||
| ], | ||
| }, | ||
| { |
There was a problem hiding this comment.
Bug: The installation instructions for Python feature flag and agent monitoring integrations no longer install required third-party libraries, causing a ModuleNotFoundError during the verification step.
Severity: HIGH
Suggested Fix
In featureFlag.tsx and agentMonitoring.tsx, update the calls to getPythonInstallCodeBlock to include the required third-party packages. For example, use the additionalPackage prop to pass the specific library needed for each integration, such as getPythonInstallCodeBlock({additionalPackage: 'launchdarkly-server-sdk'}) for LaunchDarkly or getPythonInstallCodeBlock({additionalPackage: 'langchain'}) for LangChain.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/app/gettingStartedDocs/python/featureFlag.tsx#L132-L140
Potential issue: The installation instructions for Python feature flag and agent
monitoring integrations were updated to use a new method for generating the `pip
install` command. However, the new implementation in `featureFlag.tsx` and
`agentMonitoring.tsx` omits the necessary third-party libraries (e.g.,
`launchdarkly-server-sdk`, `langchain`, `litellm`). The setup instructions now only tell
users to install `sentry-sdk`. The subsequent code examples and verification steps
require these missing libraries, which will cause a `ModuleNotFoundError` when the user
attempts to run the provided code, breaking the onboarding flow for these integrations.
3 participants
To simplify things, we're moving away from promoting installing the SDK via an extra (like
sentry-sdk[flask]).