Skip to content

chore(tracemetrics): Ensure only compatible aggregates are selected#107490

Merged
nsdeschenes merged 2 commits intomasterfrom
nd/LOGS-562/chore-tracemetrics-ensure-only-comppatible-aggs-are-selected
Feb 9, 2026
Merged

chore(tracemetrics): Ensure only compatible aggregates are selected#107490
nsdeschenes merged 2 commits intomasterfrom
nd/LOGS-562/chore-tracemetrics-ensure-only-comppatible-aggs-are-selected

Conversation

@nsdeschenes
Copy link
Contributor

This PR updates the on change handler for the multi-aggregate dropdown so that when selecting between groups, it will deselect all options not in that group.

For instance if you have per_second selected, and then select p90, per_second will be deselected.

Ticket: LOGS-562

Example:

Screen.Recording.2026-02-03.at.09.57.50.mov

@linear
Copy link

linear bot commented Feb 3, 2026

@nsdeschenes
Copy link
Contributor Author

@sentry review

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 3, 2026
@nsdeschenes
Copy link
Contributor Author

@cursor review

Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@nsdeschenes nsdeschenes marked this pull request as ready for review February 3, 2026 14:13
@nsdeschenes nsdeschenes requested a review from a team as a code owner February 3, 2026 14:13
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@nsdeschenes nsdeschenes merged commit 1dfd4f9 into master Feb 9, 2026
60 checks passed
@nsdeschenes nsdeschenes deleted the nd/LOGS-562/chore-tracemetrics-ensure-only-comppatible-aggs-are-selected branch February 9, 2026 17:29
jaydgoss pushed a commit that referenced this pull request Feb 12, 2026
…107490)

This PR updates the on change handler for the multi-aggregate dropdown
so that when selecting between groups, it will deselect all options not
in that group.

For instance if you have `per_second` selected, and then select `p90`,
`per_second` will be deselected.

Ticket: LOGS-562
@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants