chore: Use extension methods for logging #2513
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
JoshuaMoelans
left a comment
JoshuaMoelans
left a comment
There was a problem hiding this comment.
Seems like there are a few files which still have the options.DiagnosticLogger?.LogXXX syntax:
| } | ||
| catch (ThreadAbortException e) | ||
| { | ||
| Logger?.Log(SentryLevel.Debug, "ANR watchdog thread aborted.", e); |
There was a problem hiding this comment.
| Logger?.LogDebug("ANR watchdog thread aborted.", e); |
There was a problem hiding this comment.
The LogDebug has no overload that takes an exception. The ThreadAbortException is an expected scenario, i.e. when the thread is forcefully terminated during shutdown or domain unload, which is why we swallow this by simply logging.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
3 participants
Because the agent keeps getting confused by it.
#skip-changelog