Skip to content

chore(lint): Fixes lint issues#5803

Closed
antonis wants to merge 1 commit intomainfrom
antonis/lint-fixes
Closed

chore(lint): Fixes lint issues#5803
antonis wants to merge 1 commit intomainfrom
antonis/lint-fixes

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Mar 11, 2026

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fixes lint issues/warning

💡 Motivation and Context

When I run yarn fix locally I always get the formatting changes committed on this PR.

💚 How did you test it?

CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against 0c49ad6

Copy link
Contributor Author

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing since the ci c-lang formatter doesn't seem to like those changes 😅
Will revisit this later

./packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m:1017:36: error: code should be clang-formatted [-Wclang-format-violations]
    NSDictionary *userDataKeys = @{ };
                                   ^
./packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m:1034:61: error: code should be clang-formatted [-Wclang-format-violations]
    NSDictionary *userKeys = @{ @"id" : @"789", @"geo" : @ { } };
                                                            ^
./packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m:1036:36: error: code should be clang-formatted [-Wclang-format-violations]
    NSDictionary *userDataKeys = @{ };
                                   ^
./packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m:1055:36: error: code should be clang-formatted [-Wclang-format-violations]
    NSDictionary *userDataKeys = @{ };
                                   ^
Formatting [71/73] ./packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryDependencyContainerTests.m
Formatting [72/73] ./packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryOnDrawReporter+Test.h
Formatting [73/73] ./packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryStart+Test.h
ERROR: "clang:format lint" exited with 123.
ERROR: "lint:clang" exited with 1.
Error: Process completed with exit code 1.

@antonis antonis closed this Mar 11, 2026
@antonis antonis deleted the antonis/lint-fixes branch March 11, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant