Conversation
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Contributor
antonis
commented
Mar 11, 2026
Contributor
Author
antonis
left a comment
There was a problem hiding this comment.
Closing since the ci c-lang formatter doesn't seem to like those changes 😅
Will revisit this later
./packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m:1017:36: error: code should be clang-formatted [-Wclang-format-violations]
NSDictionary *userDataKeys = @{ };
^
./packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m:1034:61: error: code should be clang-formatted [-Wclang-format-violations]
NSDictionary *userKeys = @{ @"id" : @"789", @"geo" : @ { } };
^
./packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m:1036:36: error: code should be clang-formatted [-Wclang-format-violations]
NSDictionary *userDataKeys = @{ };
^
./packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryTests.m:1055:36: error: code should be clang-formatted [-Wclang-format-violations]
NSDictionary *userDataKeys = @{ };
^
Formatting [71/73] ./packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryDependencyContainerTests.m
Formatting [72/73] ./packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryOnDrawReporter+Test.h
Formatting [73/73] ./packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryStart+Test.h
ERROR: "clang:format lint" exited with 123.
ERROR: "lint:clang" exited with 1.
Error: Process completed with exit code 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fixes lint issues/warning
💡 Motivation and Context
When I run
yarn fixlocally I always get the formatting changes committed on this PR.💚 How did you test it?
CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog