test(e2e): Fix capture replay E2E test failure #5601
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ff81c0+dirty | 392.47 ms | 431.52 ms | 39.05 ms |
| 1ef8a04+dirty | 450.73 ms | 482.38 ms | 31.65 ms |
| 785ffb1+dirty | 380.65 ms | 451.83 ms | 71.18 ms |
| ba75c7c+dirty | 377.92 ms | 417.74 ms | 39.83 ms |
| 180638b+dirty | 434.46 ms | 470.90 ms | 36.44 ms |
| 8e653ac+dirty | 304.49 ms | 308.84 ms | 4.35 ms |
| 6416d6c+dirty | 469.16 ms | 508.22 ms | 39.06 ms |
| a2bb688+dirty | 371.19 ms | 389.18 ms | 17.99 ms |
| 59d1977+dirty | 366.15 ms | 393.21 ms | 27.06 ms |
| a699d13+dirty | 441.38 ms | 487.27 ms | 45.89 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ff81c0+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| 1ef8a04+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| 785ffb1+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| ba75c7c+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 180638b+dirty | 43.94 MiB | 48.91 MiB | 4.97 MiB |
| 8e653ac+dirty | 7.15 MiB | 8.46 MiB | 1.31 MiB |
| 6416d6c+dirty | 43.94 MiB | 48.88 MiB | 4.94 MiB |
| a2bb688+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 59d1977+dirty | 43.94 MiB | 49.22 MiB | 5.29 MiB |
| a699d13+dirty | 43.94 MiB | 48.88 MiB | 4.94 MiB |
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4604da9+dirty | 366.44 ms | 398.10 ms | 31.66 ms |
| 8ff81c0+dirty | 574.58 ms | 611.44 ms | 36.86 ms |
| 93137d1+dirty | 400.15 ms | 424.74 ms | 24.59 ms |
| 1ef8a04+dirty | 415.16 ms | 415.22 ms | 0.06 ms |
| a31630c+dirty | 408.91 ms | 416.80 ms | 7.89 ms |
| 11ded16+dirty | 317.29 ms | 329.15 ms | 11.86 ms |
| 180638b+dirty | 408.87 ms | 432.04 ms | 23.17 ms |
| 8e653ac+dirty | 360.28 ms | 372.04 ms | 11.76 ms |
| 6416d6c+dirty | 407.30 ms | 422.00 ms | 14.70 ms |
| 161947d+dirty | 393.26 ms | 403.00 ms | 9.74 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4604da9+dirty | 17.75 MiB | 19.74 MiB | 2.00 MiB |
| 8ff81c0+dirty | 43.75 MiB | 48.05 MiB | 4.29 MiB |
| 93137d1+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 1ef8a04+dirty | 43.75 MiB | 48.05 MiB | 4.29 MiB |
| a31630c+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 11ded16+dirty | 17.75 MiB | 19.75 MiB | 2.00 MiB |
| 180638b+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
| 8e653ac+dirty | 17.75 MiB | 19.75 MiB | 2.00 MiB |
| 6416d6c+dirty | 43.75 MiB | 48.05 MiB | 4.30 MiB |
| 161947d+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6bd9054+dirty | 1207.02 ms | 1199.27 ms | -7.76 ms |
| d73150f+dirty | 1224.52 ms | 1227.17 ms | 2.65 ms |
| d081295+dirty | 1205.24 ms | 1207.52 ms | 2.28 ms |
| d1fd647+dirty | 1218.16 ms | 1225.82 ms | 7.65 ms |
| ea3e26e+dirty | 1216.61 ms | 1214.15 ms | -2.47 ms |
| 80e4616+dirty | 1206.90 ms | 1205.94 ms | -0.96 ms |
| 955f2eb+dirty | 1225.78 ms | 1239.27 ms | 13.49 ms |
| 5ee3314+dirty | 1234.25 ms | 1235.44 ms | 1.19 ms |
| 70250df+dirty | 1211.96 ms | 1222.31 ms | 10.35 ms |
| 664c66f+dirty | 1195.94 ms | 1194.80 ms | -1.14 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6bd9054+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| d73150f+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| d081295+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| d1fd647+dirty | 3.19 MiB | 4.56 MiB | 1.37 MiB |
| ea3e26e+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 80e4616+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| 955f2eb+dirty | 3.19 MiB | 4.55 MiB | 1.36 MiB |
| 5ee3314+dirty | 3.19 MiB | 4.55 MiB | 1.37 MiB |
| 70250df+dirty | 3.44 MiB | 4.59 MiB | 1.15 MiB |
| 664c66f+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6bd9054+dirty | 1212.20 ms | 1217.89 ms | 5.70 ms |
| d73150f+dirty | 1198.44 ms | 1210.06 ms | 11.62 ms |
| d081295+dirty | 1214.40 ms | 1211.27 ms | -3.13 ms |
| d1fd647+dirty | 1219.35 ms | 1233.18 ms | 13.83 ms |
| ea3e26e+dirty | 1229.13 ms | 1228.46 ms | -0.67 ms |
| 80e4616+dirty | 1221.32 ms | 1225.64 ms | 4.32 ms |
| 955f2eb+dirty | 1235.06 ms | 1253.88 ms | 18.81 ms |
| 5ee3314+dirty | 1215.18 ms | 1207.64 ms | -7.54 ms |
| 70250df+dirty | 1214.51 ms | 1215.04 ms | 0.53 ms |
| 664c66f+dirty | 1215.37 ms | 1221.30 ms | 5.92 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6bd9054+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| d73150f+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| d081295+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| d1fd647+dirty | 2.63 MiB | 3.99 MiB | 1.36 MiB |
| ea3e26e+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 80e4616+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
| 955f2eb+dirty | 2.63 MiB | 3.98 MiB | 1.35 MiB |
| 5ee3314+dirty | 2.63 MiB | 3.99 MiB | 1.35 MiB |
| 70250df+dirty | 3.44 MiB | 4.59 MiB | 1.15 MiB |
| 664c66f+dirty | 3.38 MiB | 4.60 MiB | 1.22 MiB |
The E2E test was looking for replay_id in event._dsc.replay_id, but the Sentry API may not include _dsc in the event JSON response. The SDK correctly adds replay_id to event.contexts.replay.replay_id. Changes: - Update sentryApi.js to check event.contexts.replay.replay_id first - Fallback to event._dsc.replay_id for backwards compatibility - Add clear error message if replay_id not found in either location - Add type conversion for LaunchArguments.replaysOnErrorSampleRate to ensure it's always a number (LaunchArguments may return strings) This fixes the iOS E2E test failure that started on Jan 28, 2026 after JS SDK bump to 10.37.0. The issue was not with the SDK (replays work correctly), but with how the test verifies replay attachment. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
antonis
commented
Jan 30, 2026
| _experiments: { | ||
| replaysOnErrorSampleRate: LaunchArguments.value().replaysOnErrorSampleRate, | ||
| }, | ||
| replaysOnErrorSampleRate: LaunchArguments.value().replaysOnErrorSampleRate, |
Contributor
Author
There was a problem hiding this comment.
This change is irrelevant. It's just that replaysOnErrorSampleRate does no longer need to be under _experiments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog