-
-
Notifications
You must be signed in to change notification settings - Fork 354
chore(deps): update CLI to v3.0.0 #5471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4f6efa3 to
5f130f3
Compare
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7be1f99 | 454.83 ms | 461.36 ms | 6.53 ms |
| 3099014+dirty | 439.20 ms | 468.40 ms | 29.20 ms |
| 36841a6+dirty | 502.96 ms | 547.14 ms | 44.18 ms |
| 20d5eaa | 377.62 ms | 406.50 ms | 28.88 ms |
| a31630c+dirty | 408.91 ms | 416.80 ms | 7.89 ms |
| b3b5b0d | 399.82 ms | 419.20 ms | 19.38 ms |
| 6fee48d+dirty | 407.42 ms | 437.71 ms | 30.29 ms |
| 69602ce | 417.47 ms | 443.52 ms | 26.05 ms |
| eb07ba3 | 470.04 ms | 473.35 ms | 3.31 ms |
| 5c16cdc+dirty | 423.48 ms | 452.35 ms | 28.88 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7be1f99 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 3099014+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 36841a6+dirty | 43.75 MiB | 48.07 MiB | 4.32 MiB |
| 20d5eaa | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| a31630c+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| b3b5b0d | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 6fee48d+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 69602ce | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| eb07ba3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 5c16cdc+dirty | 17.75 MiB | 19.68 MiB | 1.94 MiB |
Previous results on branch: deps/scripts/update-cli.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6dd38c6+dirty | 456.48 ms | 503.83 ms | 47.35 ms |
| 3dae04a | 447.94 ms | 462.18 ms | 14.24 ms |
| 041780a | 432.17 ms | 425.39 ms | -6.78 ms |
| 13a0581+dirty | 419.26 ms | 443.18 ms | 23.92 ms |
| d729f18 | 407.35 ms | 416.76 ms | 9.41 ms |
| 353ab8f+dirty | 479.94 ms | 508.69 ms | 28.75 ms |
| 5592990 | 569.70 ms | 557.36 ms | -12.34 ms |
| a519ee1+dirty | 444.61 ms | 457.89 ms | 13.28 ms |
| 506f96e | 431.22 ms | 443.60 ms | 12.38 ms |
| faac064 | 435.29 ms | 460.94 ms | 25.65 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6dd38c6+dirty | 17.75 MiB | 19.69 MiB | 1.94 MiB |
| 3dae04a | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 041780a | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 13a0581+dirty | 43.75 MiB | 48.07 MiB | 4.32 MiB |
| d729f18 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| 353ab8f+dirty | 17.75 MiB | 19.71 MiB | 1.96 MiB |
| 5592990 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| a519ee1+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
| 506f96e | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| faac064 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 46bd012+dirty | 333.76 ms | 359.24 ms | 25.48 ms |
| 8ece263+dirty | 369.44 ms | 414.65 ms | 45.21 ms |
| 36841a6+dirty | 404.22 ms | 450.06 ms | 45.84 ms |
| c7f264b+dirty | 356.98 ms | 407.46 ms | 50.48 ms |
| 1853710+dirty | 360.67 ms | 396.28 ms | 35.61 ms |
| 21c9e75+dirty | 356.73 ms | 381.06 ms | 24.33 ms |
| 46da307+dirty | 356.62 ms | 415.02 ms | 58.40 ms |
| e2fa43d+dirty | 326.56 ms | 372.88 ms | 46.32 ms |
| c08359e+dirty | 406.04 ms | 428.87 ms | 22.83 ms |
| 05bef0e+dirty | 451.63 ms | 533.90 ms | 82.27 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 46bd012+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 8ece263+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 36841a6+dirty | 43.94 MiB | 48.90 MiB | 4.96 MiB |
| c7f264b+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 1853710+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 21c9e75+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 46da307+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| e2fa43d+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| c08359e+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 05bef0e+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
Previous results on branch: deps/scripts/update-cli.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5592990+dirty | 355.15 ms | 426.34 ms | 71.19 ms |
| 6dd38c6+dirty | 362.58 ms | 430.56 ms | 67.98 ms |
| 13a0581+dirty | 442.54 ms | 527.30 ms | 84.76 ms |
| 353ab8f+dirty | 314.06 ms | 323.43 ms | 9.36 ms |
| faac064+dirty | 418.02 ms | 476.34 ms | 58.32 ms |
| a519ee1+dirty | 462.20 ms | 498.71 ms | 36.50 ms |
| d729f18+dirty | 371.89 ms | 396.80 ms | 24.91 ms |
| b9b893f+dirty | 355.35 ms | 397.27 ms | 41.92 ms |
| d2cb0c0+dirty | 499.38 ms | 529.78 ms | 30.39 ms |
| bcd12b2+dirty | 376.81 ms | 404.19 ms | 27.38 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5592990+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 6dd38c6+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 13a0581+dirty | 43.94 MiB | 48.90 MiB | 4.96 MiB |
| 353ab8f+dirty | 7.15 MiB | 8.44 MiB | 1.28 MiB |
| faac064+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| a519ee1+dirty | 43.94 MiB | 48.82 MiB | 4.88 MiB |
| d729f18+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| b9b893f+dirty | 43.94 MiB | 48.90 MiB | 4.96 MiB |
| d2cb0c0+dirty | 43.94 MiB | 48.85 MiB | 4.91 MiB |
| bcd12b2+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2adbd1e+dirty | 1220.65 ms | 1230.20 ms | 9.56 ms |
| 4604da9+dirty | 1208.67 ms | 1208.12 ms | -0.54 ms |
| 9b50d32+dirty | 1210.36 ms | 1218.41 ms | 8.05 ms |
| f234eb4+dirty | 1233.52 ms | 1235.78 ms | 2.26 ms |
| 90afdd3+dirty | 1216.17 ms | 1225.55 ms | 9.38 ms |
| 161947d+dirty | 1203.45 ms | 1217.83 ms | 14.38 ms |
| 1ef8a04+dirty | 1184.42 ms | 1186.44 ms | 2.02 ms |
| 6416d6c+dirty | 1222.83 ms | 1222.04 ms | -0.79 ms |
| ebf60f9+dirty | 1218.85 ms | 1212.53 ms | -6.32 ms |
| ea3e26e+dirty | 1216.61 ms | 1214.15 ms | -2.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2adbd1e+dirty | 3.19 MiB | 4.56 MiB | 1.38 MiB |
| 4604da9+dirty | 3.19 MiB | 4.58 MiB | 1.39 MiB |
| 9b50d32+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| f234eb4+dirty | 3.19 MiB | 4.57 MiB | 1.38 MiB |
| 90afdd3+dirty | 3.19 MiB | 4.55 MiB | 1.37 MiB |
| 161947d+dirty | 3.19 MiB | 4.56 MiB | 1.37 MiB |
| 1ef8a04+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 6416d6c+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| ebf60f9+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| ea3e26e+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
Previous results on branch: deps/scripts/update-cli.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c2b7633+dirty | 1212.47 ms | 1208.62 ms | -3.85 ms |
| bcd12b2+dirty | 1225.18 ms | 1243.22 ms | 18.05 ms |
| d729f18+dirty | 1214.94 ms | 1220.65 ms | 5.72 ms |
| 3dae04a+dirty | 1231.08 ms | 1231.60 ms | 0.52 ms |
| 13a0581+dirty | 1210.44 ms | 1208.71 ms | -1.73 ms |
| faac064+dirty | 1228.92 ms | 1233.42 ms | 4.50 ms |
| b5bd9f9+dirty | 1242.47 ms | 1240.48 ms | -1.99 ms |
| d2cb0c0+dirty | 1220.34 ms | 1213.74 ms | -6.60 ms |
| 353ab8f+dirty | 1222.22 ms | 1218.79 ms | -3.44 ms |
| 506f96e+dirty | 1237.92 ms | 1250.16 ms | 12.24 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c2b7633+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| bcd12b2+dirty | 3.19 MiB | 4.56 MiB | 1.37 MiB |
| d729f18+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 3dae04a+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 13a0581+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| faac064+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| b5bd9f9+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| d2cb0c0+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 353ab8f+dirty | 3.19 MiB | 4.57 MiB | 1.38 MiB |
| 506f96e+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2adbd1e+dirty | 1207.51 ms | 1218.98 ms | 11.47 ms |
| 4604da9+dirty | 1232.59 ms | 1232.26 ms | -0.33 ms |
| 9b50d32+dirty | 1216.53 ms | 1221.64 ms | 5.10 ms |
| f234eb4+dirty | 1227.22 ms | 1228.45 ms | 1.22 ms |
| 90afdd3+dirty | 1233.90 ms | 1240.90 ms | 7.00 ms |
| 161947d+dirty | 1203.43 ms | 1217.00 ms | 13.57 ms |
| 1ef8a04+dirty | 1226.14 ms | 1223.15 ms | -2.99 ms |
| 6416d6c+dirty | 1220.38 ms | 1222.98 ms | 2.60 ms |
| ebf60f9+dirty | 1217.66 ms | 1214.82 ms | -2.84 ms |
| ea3e26e+dirty | 1229.13 ms | 1228.46 ms | -0.67 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2adbd1e+dirty | 2.63 MiB | 4.00 MiB | 1.36 MiB |
| 4604da9+dirty | 2.63 MiB | 4.01 MiB | 1.38 MiB |
| 9b50d32+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| f234eb4+dirty | 2.63 MiB | 4.00 MiB | 1.37 MiB |
| 90afdd3+dirty | 2.63 MiB | 3.99 MiB | 1.35 MiB |
| 161947d+dirty | 2.63 MiB | 3.99 MiB | 1.36 MiB |
| 1ef8a04+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 6416d6c+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| ebf60f9+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| ea3e26e+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
Previous results on branch: deps/scripts/update-cli.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c2b7633+dirty | 1198.22 ms | 1213.00 ms | 14.78 ms |
| bcd12b2+dirty | 1239.73 ms | 1248.58 ms | 8.85 ms |
| d729f18+dirty | 1214.91 ms | 1244.36 ms | 29.45 ms |
| 3dae04a+dirty | 1207.88 ms | 1213.21 ms | 5.33 ms |
| 13a0581+dirty | 1214.72 ms | 1212.79 ms | -1.93 ms |
| faac064+dirty | 1225.85 ms | 1232.59 ms | 6.74 ms |
| b5bd9f9+dirty | 1216.04 ms | 1242.70 ms | 26.66 ms |
| d2cb0c0+dirty | 1216.09 ms | 1218.98 ms | 2.89 ms |
| 353ab8f+dirty | 1232.65 ms | 1238.42 ms | 5.76 ms |
| 506f96e+dirty | 1228.10 ms | 1230.60 ms | 2.50 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c2b7633+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| bcd12b2+dirty | 2.63 MiB | 3.99 MiB | 1.36 MiB |
| d729f18+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 3dae04a+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 13a0581+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| faac064+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| b5bd9f9+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| d2cb0c0+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 353ab8f+dirty | 2.63 MiB | 4.00 MiB | 1.37 MiB |
| 506f96e+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
lucas-zimerman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error is unrelated to the PR, LGTM!
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error is unrelated to the PR, LGTM!
I agree @lucas-zimerman 👍
I was wondering since this is a major bump if it would make sense to target v8. On the other hand since the CI is 🟢 I don't expect any breakages and it is probably fine to ship in the next minor release. Wdyt?
You have a good point, Despite not being a break change to Sentry.io users, it surely will be for self-hosted users. |
lucas-zimerman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets move to V8 and not main
Ok. Marking as |
Bumps scripts/update-cli.sh from 2.58.4 to 3.0.0.
Auto-generated by a dependency updater.
Changelog
3.0.0
New Sentry Support Policy
sentry-cli3.0.0 and above only officially supports Sentry SaaS and Sentry self-hosted versions 25.11.1 and higher. While many Sentry CLI features may, in practice, continue working with some older Sentry versions, continued support for Sentry versions older than 25.11.1 is not guaranteed. Changes which break support for Sentry versions below 25.11.1 may occur in minor or patch releases.New Versioning Policy
Sentry CLI now defines a semantic versioning policy. We did not explicitly define a versioning policy before, but the new versioning policy contains some notable changes versus the previous implicit policy we had been following. The main change is that dropping support for self-hosted Sentry versions now only requires a minor version bump, although such changes will be clearly communicated in the changelog.
Important
Self-hosted users: We strongly recommend pinning your Sentry CLI version, since Sentry CLI may drop support for your self-hosted Sentry version in any future minor release. Always check the changelog before upgrading Sentry CLI.
Breaking Changes
sentry-cli files ...andsentry-cli releases files ...subcommands (#2956). These commands provided functionality for managing release files, a feature that has been deprecated in Sentry. Users still usingsentry-cli files uploadto upload source maps should migrate tosentry-cli sourcemaps upload.sentry-cli sourcemaps explaincommand (#2947). The command had been deprecated for some time, since Sentry now has a better in-product debugging flow for source map problems via the "Unminify Code" button, which is displayed on any JavaScript issues which could not be unminified.sentry-cli send-metric ...subcommands (#3006). These commands have been deprecated, and the data they send is no longer accepted by Sentry.--api-keyCLI flagSENTRY_API_KEYenvironment variableapi_keyconfiguration file fieldapiKeyoption in the JavaScript APIupload-proguardsubcommand's--app-id,--version,--version-code,--android-manifest, and--platformarguments (#2876, #2940, #2948). Users using these arguments should stop using them, as they are unnecessary. The information passed to these arguments is no longer visible in Sentry.--startedargument from thesentry-cli releases finalizecommand (#2972). This argument is a no-op, so any users using it should simply stop using it.--use-artifact-bundleflag fromsentry-cli sourcemaps upload(#3002). The flag was a no-op that only emitted a deprecation warning.Node.js Wrapper Breakages
The following changes only apply when using
sentry-clivia the npm packagesentry/cli:The
SentryCli.executemethod'sliveparameter now only takes boolean values (#2971). Settinglivetotruenow behaves like'rejectOnError'did previously, with a zero exit status resolving the returned promise with"success (live mode)"and a non-zero status rejecting the promise with an error message.The
optionparameter toReleases.uploadSourceMapsno longer takes aliveproperty (#2971). We now always execute the command withliveset totrue.Removed the
apiKeyoption fromSentryCliOptions(#2935). If you are usingapiKey, you need to generate and use an Auth Token via theauthTokenoption, instead.Removed the
useArtifactBundleoption fromSentryCliUploadSourceMapsOptions(#3002). This deprecated option was a no-op that users should simply stop passing.Drop support for Node.js <18. The minimum required Node.js version is now 18.0.0 (#2985).
The type export
SentryCliReleaseshas been removed.The JavaScript wrapper now uses named exports instead of default exports (#2989). You need to update your imports:
For ESM imports:
Improvements
sentry-cli upload-proguardcommand now uses chunked uploading by default (#2918). Users who previously set theSENTRY_EXPERIMENTAL_PROGUARD_CHUNK_UPLOADenvironment variable to opt into this behavior no longer need to set the variable.debugIdfield, per the TC39 Debug ID proposal (#3005). This change affects thesentry-cli sourcemaps injectcommand and, unless--no-rewriteis passed, thesentry-cli sourcemaps uploadcommand. Sentry CLI can still read thedebug_idfield, but whenever the CLI writes or rewrites a source map, we always usedebugId.sentry-cli build uploadcommand now automatically tracks Sentry plugin versions from theSENTRY_PIPELINEenvironment variable (#2994). WhenSENTRY_PIPELINEcontains a recognized Sentry plugin (e.g.,sentry-gradle-plugin/4.12.0orsentry-fastlane-plugin/1.2.3), the plugin version is written to the.sentry-cli-metadata.txtfile in uploaded build archives, enabling the backend to store metadata for size analysis and build distribution tracking.Fixes