Bump e2e tests and sample apps to XCode 26 #5467

alwx · 2025-12-15T09:42:23Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Fixes #5457

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

.github/workflows/e2e-v2.yml

github-actions · 2025-12-15T09:59:29Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	361.54 ms	373.70 ms	12.16 ms
Size	43.94 MiB	48.90 MiB	4.96 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`46bd012`+dirty	333.76 ms	359.24 ms	25.48 ms
`8ece263`+dirty	369.44 ms	414.65 ms	45.21 ms
`36841a6`+dirty	404.22 ms	450.06 ms	45.84 ms
`c7f264b`+dirty	356.98 ms	407.46 ms	50.48 ms
`1853710`+dirty	360.67 ms	396.28 ms	35.61 ms
`21c9e75`+dirty	356.73 ms	381.06 ms	24.33 ms
`46da307`+dirty	356.62 ms	415.02 ms	58.40 ms
`e2fa43d`+dirty	326.56 ms	372.88 ms	46.32 ms
`c08359e`+dirty	406.04 ms	428.87 ms	22.83 ms
`05bef0e`+dirty	451.63 ms	533.90 ms	82.27 ms

App size

Revision	Plain	With Sentry	Diff
`46bd012`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`8ece263`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`36841a6`+dirty	43.94 MiB	48.90 MiB	4.96 MiB
`c7f264b`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`1853710`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`21c9e75`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`46da307`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`e2fa43d`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`c08359e`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`05bef0e`+dirty	7.15 MiB	8.43 MiB	1.28 MiB

github-actions · 2025-12-15T10:00:48Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	406.29 ms	426.00 ms	19.71 ms
Size	43.75 MiB	48.07 MiB	4.32 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`7be1f99`	454.83 ms	461.36 ms	6.53 ms
`3099014`+dirty	439.20 ms	468.40 ms	29.20 ms
`36841a6`+dirty	502.96 ms	547.14 ms	44.18 ms
`20d5eaa`	377.62 ms	406.50 ms	28.88 ms
`a31630c`+dirty	408.91 ms	416.80 ms	7.89 ms
`b3b5b0d`	399.82 ms	419.20 ms	19.38 ms
`6fee48d`+dirty	407.42 ms	437.71 ms	30.29 ms
`69602ce`	417.47 ms	443.52 ms	26.05 ms
`eb07ba3`	470.04 ms	473.35 ms	3.31 ms
`5c16cdc`+dirty	423.48 ms	452.35 ms	28.88 ms

App size

Revision	Plain	With Sentry	Diff
`7be1f99`	17.75 MiB	20.15 MiB	2.41 MiB
`3099014`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`36841a6`+dirty	43.75 MiB	48.07 MiB	4.32 MiB
`20d5eaa`	17.75 MiB	20.15 MiB	2.41 MiB
`a31630c`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`b3b5b0d`	17.75 MiB	19.68 MiB	1.94 MiB
`6fee48d`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`69602ce`	17.75 MiB	19.68 MiB	1.94 MiB
`eb07ba3`	17.75 MiB	20.15 MiB	2.41 MiB
`5c16cdc`+dirty	17.75 MiB	19.68 MiB	1.94 MiB

github-actions · 2025-12-15T10:10:16Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1214.41 ms	1214.84 ms	0.44 ms
Size	3.41 MiB	4.58 MiB	1.17 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`2adbd1e`+dirty	1220.65 ms	1230.20 ms	9.56 ms
`4604da9`+dirty	1208.67 ms	1208.12 ms	-0.54 ms
`9b50d32`+dirty	1210.36 ms	1218.41 ms	8.05 ms
`f234eb4`+dirty	1233.52 ms	1235.78 ms	2.26 ms
`90afdd3`+dirty	1216.17 ms	1225.55 ms	9.38 ms
`161947d`+dirty	1203.45 ms	1217.83 ms	14.38 ms
`1ef8a04`+dirty	1184.42 ms	1186.44 ms	2.02 ms
`6416d6c`+dirty	1222.83 ms	1222.04 ms	-0.79 ms
`ebf60f9`+dirty	1218.85 ms	1212.53 ms	-6.32 ms
`ea3e26e`+dirty	1216.61 ms	1214.15 ms	-2.47 ms

App size

Revision	Plain	With Sentry	Diff
`2adbd1e`+dirty	3.19 MiB	4.56 MiB	1.38 MiB
`4604da9`+dirty	3.19 MiB	4.58 MiB	1.39 MiB
`9b50d32`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`f234eb4`+dirty	3.19 MiB	4.57 MiB	1.38 MiB
`90afdd3`+dirty	3.19 MiB	4.55 MiB	1.37 MiB
`161947d`+dirty	3.19 MiB	4.56 MiB	1.37 MiB
`1ef8a04`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`6416d6c`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`ebf60f9`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB

github-actions · 2025-12-15T10:10:41Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1224.66 ms	1223.61 ms	-1.05 ms
Size	3.41 MiB	4.58 MiB	1.17 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`2adbd1e`+dirty	1207.51 ms	1218.98 ms	11.47 ms
`4604da9`+dirty	1232.59 ms	1232.26 ms	-0.33 ms
`9b50d32`+dirty	1216.53 ms	1221.64 ms	5.10 ms
`f234eb4`+dirty	1227.22 ms	1228.45 ms	1.22 ms
`90afdd3`+dirty	1233.90 ms	1240.90 ms	7.00 ms
`161947d`+dirty	1203.43 ms	1217.00 ms	13.57 ms
`1ef8a04`+dirty	1226.14 ms	1223.15 ms	-2.99 ms
`6416d6c`+dirty	1220.38 ms	1222.98 ms	2.60 ms
`ebf60f9`+dirty	1217.66 ms	1214.82 ms	-2.84 ms
`ea3e26e`+dirty	1229.13 ms	1228.46 ms	-0.67 ms

App size

Revision	Plain	With Sentry	Diff
`2adbd1e`+dirty	2.63 MiB	4.00 MiB	1.36 MiB
`4604da9`+dirty	2.63 MiB	4.01 MiB	1.38 MiB
`9b50d32`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`f234eb4`+dirty	2.63 MiB	4.00 MiB	1.37 MiB
`90afdd3`+dirty	2.63 MiB	3.99 MiB	1.35 MiB
`161947d`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`1ef8a04`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`6416d6c`+dirty	3.41 MiB	4.59 MiB	1.18 MiB
`ebf60f9`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB

.github/workflows/testflight.yml

lucas-zimerman

Thank you for the PR!
Lets merge it once all tests are passing

.github/workflows/e2e-v2.yml

      - uses: ruby/setup-ruby@v1
        if: ${{ matrix.platform == 'ios' }}
        with:
-          working-directory: dev-packages/e2e-tests/react-native-versions/${{ matrix.rn-version }}/RnDiffApp
          ruby-version: '3.3.0' # based on what is used in the sample
          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
          cache-version: 1 # cache the installed gems

+      - name: Setup Plain RN ${{ matrix.rn-version }} App
+        run: ./dev-packages/e2e-tests/cli.mjs ${{ matrix.platform }} --create


.github/workflows/e2e-v2.yml

+
      - name: Build Plain RN ${{ matrix.rn-version }} App
        run: ./dev-packages/e2e-tests/cli.mjs ${{ matrix.platform }} --build



.github/workflows/e2e-v2.yml

sentry · 2025-12-15T14:31:46Z

samples/react-native-macos/macos/Podfile

 prepare_react_native_project!

 target 'sentry-react-native-sample-macOS' do
-  platform :macos, '10.15'
+  platform :macos, '11'
  use_native_modules!

  # Flags change depending on the env values.


Bug: The Podfile specifies platform :macos, '11', but the Xcode project's MACOSX_DEPLOYMENT_TARGET is still 10.15. This inconsistency will cause build failures.
_{Severity: CRITICAL | Confidence: High}

🔍 Detailed Analysis

The pull request updates the macOS platform target in the Podfile to 11 but fails to update the corresponding MACOSX_DEPLOYMENT_TARGET in the Xcode project file, which remains 10.15. This discrepancy creates a conflict. CocoaPods will resolve dependencies based on macOS 11, but the project is configured to build for macOS 10.15. This will lead to build failures, likely during dependency resolution or the linking phase, as frameworks compiled for macOS 11 may not be compatible with a macOS 10.15 target.

💡 Suggested Fix

Update the MACOSX_DEPLOYMENT_TARGET setting in the project.pbxproj file for both the Debug and Release configurations to 11 to match the platform version specified in the Podfile. This will ensure consistency between the project settings and CocoaPods dependencies.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: samples/react-native-macos/macos/Podfile#L4-L10 Potential issue: The pull request updates the macOS platform target in the `Podfile` to `11` but fails to update the corresponding `MACOSX_DEPLOYMENT_TARGET` in the Xcode project file, which remains `10.15`. This discrepancy creates a conflict. CocoaPods will resolve dependencies based on macOS 11, but the project is configured to build for macOS 10.15. This will lead to build failures, likely during dependency resolution or the linking phase, as frameworks compiled for macOS 11 may not be compatible with a macOS 10.15 target.

_{Did we get this right? 👍 / 👎 to inform future reviews.}
_{Reference ID: 7525881}

Bump e2e tests and sample apps to XCode 26

e11584d

alwx self-assigned this Dec 15, 2025

alwx requested review from antonis and lucas-zimerman as code owners December 15, 2025 09:42

antonis added the ready-to-merge Triggers the full CI test suite label Dec 15, 2025

antonis reviewed Dec 15, 2025

View reviewed changes

.github/workflows/e2e-v2.yml Show resolved Hide resolved

alwx added 2 commits December 15, 2025 11:15

Merge branch 'main' into alwx/improvement/macos26

045688b

Trying it with Cirrus Labs

35b9375

sentry bot reviewed Dec 15, 2025

View reviewed changes

.github/workflows/testflight.yml Show resolved Hide resolved

Native tests

3959876

lucas-zimerman reviewed Dec 15, 2025

View reviewed changes

alwx added 3 commits December 15, 2025 13:33

Fix

9c4c752

Small fix

3af0e68

Fixes

f2834f5

sentry bot reviewed Dec 15, 2025

View reviewed changes

Fix

60642fa

sentry bot reviewed Dec 15, 2025

View reviewed changes

.github/workflows/e2e-v2.yml Outdated Show resolved Hide resolved

alwx added 2 commits December 15, 2025 14:41

Test fixes

7e73ee1

Fixes

33a13d1

sentry bot reviewed Dec 15, 2025

View reviewed changes


		- name: Build Plain RN ${{ matrix.rn-version }} App
		run: ./dev-packages/e2e-tests/cli.mjs ${{ matrix.platform }} --build

Uh oh!

Bump e2e tests and sample apps to XCode 26 #5467

Are you sure you want to change the base?

Bump e2e tests and sample apps to XCode 26 #5467

Conversation

alwx commented Dec 15, 2025

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

sentry bot Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Dec 15, 2025 •

edited

Loading

github-actions bot commented Dec 15, 2025 •

edited

Loading

github-actions bot commented Dec 15, 2025 •

edited

Loading

github-actions bot commented Dec 15, 2025 •

edited

Loading