-
Notifications
You must be signed in to change notification settings - Fork 572
feat(integration): add gen_ai.conversation.id if available
#5307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
constantinius
wants to merge
12
commits into
master
Choose a base branch
from
constantinius/feat/integrations/openai-agents-conversation-id
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e5ad308
feat(integrations): openai-agents streaming support
constantinius 8884375
fix: improved instrumentation
constantinius c446c35
fix: improving span data support for streaming responses
constantinius ca2b9ba
rev: reverting mcp
constantinius e5d0ffa
feat: deduplicating code
constantinius 5e0d558
Merge branch 'master' into constantinius/feat/integrations/openai-age…
constantinius 5f73e4f
fix: mypy lint issues
constantinius b09e718
fix: several review comments
constantinius 635606f
fix: missing workflow span closing
constantinius fcd77a7
fix: review comment and deslop
constantinius c67deeb
feat(integrations): if there's a conversation id we use that for `gen…
constantinius 621766c
fix: simplifying the implementation of conversation tracking
constantinius File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| from .models import _create_get_model_wrapper # noqa: F401 | ||
| from .tools import _create_get_all_tools_wrapper # noqa: F401 | ||
| from .runner import _create_run_wrapper # noqa: F401 | ||
| from .runner import _create_run_wrapper, _create_run_streamed_wrapper # noqa: F401 | ||
| from .agent_run import _patch_agent_run # noqa: F401 | ||
| from .error_tracing import _patch_error_tracing # noqa: F401 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The
_sentry_conversation_idis not propagated to secondary agents during handoffs, causing subsequent spans for that agent to lack the conversation ID and breaking trace continuity.Severity: HIGH
Suggested Fix
Propagate the
_sentry_conversation_idto handoff agents before they are executed. This could be achieved by setting the attribute on the handoff agent object before it is used in_run_single_turn, or by storing theconversation_idin a context that persists across handoffs, ensuring all agents in the chain have access to it.Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.