chore(ci): update PHPUnit versions in CI matrix #2001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Litarnus
approved these changes
Jan 30, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| * @see https://www.php.net/manual/en/language.oop5.magic.php#object.sleep | ||
| */ | ||
| public function __sleep() | ||
| public function __serialize() |
There was a problem hiding this comment.
Serialization protection broken for PHP 7.2 and 7.3
High Severity
The __sleep() and __wakeup() methods were replaced with __serialize() and __unserialize(), but these magic methods were only introduced in PHP 7.4. Since the project supports PHP 7.2+ (per composer.json), on PHP 7.2 and 7.3 these methods won't be called during serialization, breaking the singleton pattern protection. Users on those PHP versions could now serialize/unserialize the HubAdapter singleton.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates PHPUnit versions in the CI workflow matrix to the latest releases:
^8.5.40→^8.5.52(for PHP 7.2)^9.6.21/^9.6.25→^9.6.33(for PHP 7.3-8.5)This ensures we're testing against the latest patch releases which include
bug fixes and compatibility improvements.