fix: clean up inproc handler sync#1533
Merged
supervacuus merged 5 commits intomasterfrom Feb 19, 2026
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
56f32d6 to
f70d15d
Compare
…in CI also make abort() popups on Windows a global config for the inproc stress test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just saw that, due to the wait for the
inprochandler thread in the recent changes, ourinprocinit benchmark regressed unnecessarily because of the poll loop's rather coarse 10ms granularity.I took this as an inspiration to clean up the handler sync a bit:
pollfdon apipeandWaitForSingleObjecton anEventrespectively) with a timeout. That should dramatically reduce the init wait without any wasteful sleeping on our side.Would be great to pack this in before the breaking
0.13.0.(since this is a follow-up to the unreleased #1446)
#skip-changelog