Skip to content

fix(Prisma): update span description for Prisma v7+ #19924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julien1619 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(Prisma): update span description for Prisma v7+ #19924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/node/src/integrations/tracing/prisma.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export const prismaIntegration = defineIntegration((options?: PrismaOptions) =>
}

// Make sure we use the query text as the span name, for ex. SELECT * FROM "User" WHERE "id" = $1
if (spanJSON.description === 'prisma:engine:db_query' && spanJSON.data['db.query.text']) {
if ((spanJSON.description === 'prisma:engine:db_query' || spanJSON.description === 'prisma:client:db_query') && spanJSON.data['db.query.text']) {
Copy link

@cursor cursor bot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix PR lacks test verifying the regression fix

Medium Severity

This fix PR does not include a test that verifies the regression is actually fixed. The existing v7 integration test at prisma-orm-v7/test.ts expects description === 'prisma:client:db_query' (the unfixed behavior), meaning it either doesn't cover this fix at all, or the fix is ineffective because db.query.text isn't available at spanStart time for v7. Compare with the v6 test, which properly asserts the description is updated to the actual SQL query text. A test confirming the span description gets updated for prisma:client:db_query spans is needed.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

span.updateName(spanJSON.data['db.query.text'] as string);
}

Expand Down
Loading