fix(react-router): Disable debug ID injection in Vite plugin to prevent double injection#19890
Open
fix(react-router): Disable debug ID injection in Vite plugin to prevent double injection#19890
Conversation
…nt double injection Set sourcemaps.disable to true (boolean) instead of 'disable-upload' (string) in makeCustomSentryVitePlugins. The Rollup plugin checks disable !== true, so the string value was not disabling debug ID injection. This caused double injection with two different UUIDs per file when sentryOnBuildEnd also ran sentry-cli sourcemaps inject, breaking source map resolution. Fixes GH-19874 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
size-limit report 📦
|
chargome
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
makeCustomSentryVitePluginsfunction was passingsourcemaps: { disable: 'disable-upload' }to the Sentry Vite plugin. However, the underlying Rollup plugin checksdisable !== true, so the string value'disable-upload'did not actually disable debug ID injection.This caused double injection: once by the Vite plugin (during build), and again by
sentryOnBuildEndviasentry-cli sourcemaps inject. Each injection assigned a different UUID to the same file, breaking source map resolution.Fix: change
disablefrom'disable-upload'totrueso the Rollup plugin correctly skips debug ID injection, leaving the full injection pass tosentryOnBuildEnd.Closes #19874