Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@types/node": "^18.19.1",
"@types/react": "18.0.26",
"@types/react-dom": "18.0.9",
"next": "14.2.35",
"next": "15.5.10",
"react": "18.2.0",
"react-dom": "18.2.0",
"typescript": "~5.0.0"
Comment on lines 20 to 22
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The create-next-app test application pins react and react-dom to 18.2.0 while upgrading to Next.js 15, which is inconsistent with other Next.js 15 test apps that use "latest".
Severity: MEDIUM

Suggested Fix

Update the package.json for the create-next-app test application. Change the versions of react and react-dom from 18.2.0 to "latest". Also, update @types/react and @types/react-dom to more recent versions to align with the dependency patterns of other Next.js 15 test applications in the repository.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: dev-packages/e2e-tests/test-applications/create-next-app/package.json#L20-L22

Potential issue: The `create-next-app` test application is being upgraded to Next.js
15.5.10 but retains pinned dependencies for `react` and `react-dom` at `18.2.0`, along
with outdated type definitions. This is inconsistent with other Next.js 15 test
applications in the repository, which use `"latest"` for React. This version mismatch is
likely to cause peer dependency errors during installation, potentially failing the CI
build. It also introduces a risk of runtime API incompatibilities between Next.js 15 and
the older React version, which could cause the E2E tests to fail.

Did we get this right? 👍 / 👎 to inform future reviews.

Expand Down
Loading