Skip to content

Conversation

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

"@types/react-dom": "18.3.1",
"@types/node": "^20",
"@react-router/dev": "7.9.6",
"@react-router/dev": "7.13.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential p-map version conflict with pnpm override

Low Severity

The upgrade to @react-router/dev 7.13.0 introduces a new dependency on p-map@^7.0.3. However, these two test applications have existing pnpm overrides that force p-map to ^4.0.0. This version mismatch could cause compatibility issues or unexpected behavior since the new @react-router/dev may use APIs or features specific to p-map v7 that don't exist in v4.

Additional Locations (1)

Fix in Cursor Fix in Web

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,924 - 8,823 +1%
GET With Sentry 1,703 19% 1,686 +1%
GET With Sentry (error only) 6,043 68% 6,159 -2%
POST Baseline 1,184 - 1,200 -1%
POST With Sentry 586 49% 569 +3%
POST With Sentry (error only) 1,043 88% 1,043 -
MYSQL Baseline 3,270 - 3,302 -1%
MYSQL With Sentry 438 13% 445 -2%
MYSQL With Sentry (error only) 2,659 81% 2,653 +0%

View base workflow run

@s1gr1d s1gr1d enabled auto-merge (squash) January 28, 2026 12:51
@s1gr1d s1gr1d merged commit 62bf7cc into develop Jan 28, 2026
216 checks passed
@s1gr1d s1gr1d deleted the sig/react-router-update branch January 28, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(deps): Upgrade react-router, @react-router/node, @react-router/serve, @react-router/dev to 7.13.0

4 participants