Skip to content

Conversation

@andreiborza
Copy link
Member

@andreiborza andreiborza commented Jan 27, 2026

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 11,117 - 8,864 +25%
GET With Sentry 1,840 17% 1,737 +6%
GET With Sentry (error only) 7,224 65% 6,110 +18%
POST Baseline 1,099 - 1,217 -10%
POST With Sentry 512 47% 590 -13%
POST With Sentry (error only) 1,011 92% 1,058 -4%
MYSQL Baseline 3,867 - 3,328 +16%
MYSQL With Sentry 483 12% 501 -4%
MYSQL With Sentry (error only) 3,217 83% 2,708 +19%

View base workflow run

- npm
- yarn
- pnpm
- bun
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deno 😢

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add a "Other"? You'll never know what will come tomorrow

@andreiborza andreiborza enabled auto-merge (squash) January 27, 2026 15:05
@andreiborza andreiborza disabled auto-merge January 27, 2026 16:41
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Copy link
Member

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep an eye on the auto labeling and see if this one breaks

Comment on lines +132 to +140
const labels = Array.from(labelsToAdd).join('\n');
console.log('Detected labels:', labels);
core.setOutput('labels', labels);

- name: Add package labels if applicable
if: steps.packageLabels.outputs.labels != ''
uses: actions-ecosystem/action-add-labels@v1
with:
labels: ${{ steps.additionalLabel.outputs.label }}
labels: ${{ steps.packageLabels.outputs.labels }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The action-add-labels step incorrectly consumes multiline label output from a script because the YAML syntax is missing the required pipe operator (|) for multiline strings.
Severity: MEDIUM

Suggested Fix

Modify the action-add-labels step to use the YAML pipe operator for the labels input. This ensures the newline-separated string from the previous step is correctly interpreted as a list of labels.

- name: Add Package Labels
  uses: actions/add-to-project@v1
  with:
    labels: |
      ${{ steps.packageLabels.outputs.labels }}
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/issue-package-label.yml#L132-L140

Potential issue: A `github-script` step generates a newline-separated string of labels
and sets it as an output. This output is then passed to the `action-add-labels` action
at line 140. However, the YAML syntax `labels: ${{ steps.packageLabels.outputs.labels
}}` does not use the pipe operator (`|`), which is required to correctly interpret a
multiline string in YAML. This will likely cause the action to fail when attempting to
add multiple labels, such as when an issue report contains multiple `@sentry/*`
packages, defeating the purpose of the automation.

@andreiborza
Copy link
Member Author

Actually, our current template is less friction for users. They might not report 100% accurately but those would probably not run envinfo anyway. Closing this.

@andreiborza andreiborza deleted the ab/bug-template-envinfo branch January 28, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Add System Info and Package Manager fields to bug template

4 participants