-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore: Add System Info and Package Manager fields to bug template #18990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
| - npm | ||
| - yarn | ||
| - pnpm | ||
| - bun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deno 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add a "Other"? You'll never know what will come tomorrow
…heck envinfo output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
JPeer264
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep an eye on the auto labeling and see if this one breaks
| const labels = Array.from(labelsToAdd).join('\n'); | ||
| console.log('Detected labels:', labels); | ||
| core.setOutput('labels', labels); | ||
|
|
||
| - name: Add package labels if applicable | ||
| if: steps.packageLabels.outputs.labels != '' | ||
| uses: actions-ecosystem/action-add-labels@v1 | ||
| with: | ||
| labels: ${{ steps.additionalLabel.outputs.label }} | ||
| labels: ${{ steps.packageLabels.outputs.labels }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The action-add-labels step incorrectly consumes multiline label output from a script because the YAML syntax is missing the required pipe operator (|) for multiline strings.
Severity: MEDIUM
Suggested Fix
Modify the action-add-labels step to use the YAML pipe operator for the labels input. This ensures the newline-separated string from the previous step is correctly interpreted as a list of labels.
- name: Add Package Labels
uses: actions/add-to-project@v1
with:
labels: |
${{ steps.packageLabels.outputs.labels }}Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/workflows/issue-package-label.yml#L132-L140
Potential issue: A `github-script` step generates a newline-separated string of labels
and sets it as an output. This output is then passed to the `action-add-labels` action
at line 140. However, the YAML syntax `labels: ${{ steps.packageLabels.outputs.labels
}}` does not use the pipe operator (`|`), which is required to correctly interpret a
multiline string in YAML. This will likely cause the action to fail when attempting to
add multiple labels, such as when an issue report contains multiple `@sentry/*`
packages, defeating the purpose of the automation.
|
Actually, our current template is less friction for users. They might not report 100% accurately but those would probably not run envinfo anyway. Closing this. |
Inspired by https://github.com/remix-run/react-router/blob/8cb826426cf89ef6d89f84339ea4b90e60d2a34d/.github/ISSUE_TEMPLATE/bug_report.yml?plain=1#L45-L63
Closes #18992 (added automatically)