Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions dev-packages/rollup-utils/npmHelpers.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,6 @@ export function makeBaseNPMConfig(options = {}) {
// Include __esModule property when there is a default prop
esModule: 'if-default-prop',

// output individual files rather than one big bundle
preserveModules: true,

// output files relative to the src directory
preserveModulesRoot: 'src',

// Allow wrappers or helper functions generated by rollup to use any ES2015 features
generatedCode: {
preset: 'es2015',
Expand Down
1 change: 0 additions & 1 deletion dev-packages/test-utils/rollup.npm.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ export default makeNPMConfigVariants(
output: {
// set exports to 'named' or 'auto' so that rollup doesn't warn
exports: 'named',
preserveModules: false,
},
},
}),
Expand Down
6 changes: 3 additions & 3 deletions packages/astro/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
},
"./middleware": {
"types": "./build/types/integration/middleware/index.types.d.ts",
"node": "./build/esm/integration/middleware/index.js",
"import": "./build/esm/integration/middleware/index.js",
"require": "./build/cjs/integration/middleware/index.js"
"node": "./build/esm/middleware.js",
"import": "./build/esm/middleware.js",
"require": "./build/cjs/middleware.js"
},
"./import": {
"import": {
Expand Down
4 changes: 1 addition & 3 deletions packages/astro/rollup.npm.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,13 @@ import { makeBaseNPMConfig, makeNPMConfigVariants, makeOtelLoaders } from '@sent

const variants = makeNPMConfigVariants(
makeBaseNPMConfig({
entrypoints: ['src/index.server.ts', 'src/index.client.ts', 'src/integration/middleware/index.ts'],
entrypoints: ['src/index.server.ts', 'src/index.client.ts', 'src/integration/middleware.ts'],
packageSpecificConfig: {
output: {
dynamicImportInCjs: true,
exports: 'named',
},
},
// Astro is Node 18+ no need to add polyfills
addPolyfills: false,
}),
);

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { MiddlewareResponseHandler } from 'astro';
import { handleRequest } from '../../server/middleware';
import { handleRequest } from '../server/middleware';

/**
* This export is used by our integration to automatically add the middleware
Expand Down
2 changes: 1 addition & 1 deletion packages/browser-utils/rollup.npm.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default makeNPMConfigVariants(
// set preserveModules to true because we don't want to bundle everything into one file.
preserveModules:
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
? true
? false
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
},
},
Expand Down
2 changes: 1 addition & 1 deletion packages/browser/rollup.npm.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default makeNPMConfigVariants(
// set preserveModules to true because we don't want to bundle everything into one file.
preserveModules:
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
? true
? false
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
},
},
Expand Down
3 changes: 1 addition & 2 deletions packages/core/rollup.npm.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,9 @@ export default makeNPMConfigVariants(
output: {
// set exports to 'named' or 'auto' so that rollup doesn't warn
exports: 'named',
// set preserveModules to true because we don't want to bundle everything into one file.
preserveModules:
process.env.SENTRY_BUILD_PRESERVE_MODULES === undefined
? true
? false
: Boolean(process.env.SENTRY_BUILD_PRESERVE_MODULES),
},
plugins: [
Expand Down
34 changes: 29 additions & 5 deletions packages/nextjs/rollup.npm.config.mjs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { makeBaseNPMConfig, makeNPMConfigVariants, makeOtelLoaders } from '@sentry-internal/rollup-utils';
import path from 'path';

export default [
...makeNPMConfigVariants(
Expand Down Expand Up @@ -55,7 +56,7 @@ export default [

packageSpecificConfig: {
output: {
virtualDirname: '_virtual/loaders',
virtualDirname: '_virtual/templates',

// this is going to be add-on code, so it doesn't need the trappings of a full module (and in fact actively
// shouldn't have them, lest they muck with the module to which we're adding it)
Expand Down Expand Up @@ -101,22 +102,45 @@ import * as serverComponentModule from "__SENTRY_WRAPPING_TARGET_FILE__";${code.
],
},
}),
),
).map(v => {
// copy the templates into the config/templates directory relative to the esm/cjs build directory
return {
...v,
output: {
...v.output,
dir: path.join(v.output.dir, 'config/templates'),
},
};
}),
...makeNPMConfigVariants(
makeBaseNPMConfig({
entrypoints: ['src/config/loaders/index.ts'],
entrypoints: [
'src/config/loaders/index.ts',
'src/config/loaders/valueInjectionLoader.ts',
'src/config/loaders/prefixLoader.ts',
'src/config/loaders/wrappingLoader.ts',
],

packageSpecificConfig: {
output: {
virtualDirname: '_virtual/polyfills',
virtualDirname: '_virtual/loaders',

// make it so Rollup calms down about the fact that we're combining default and named exports
exports: 'named',
},
external: ['@rollup/plugin-commonjs', 'rollup'],
},
}),
),
).map(v => {
// copy the loaders into the config/loaders directory relative to the esm/cjs build directory
return {
...v,
output: {
...v.output,
dir: path.join(v.output.dir, 'config/loaders'),
},
};
}),
...makeNPMConfigVariants(
makeBaseNPMConfig({
entrypoints: ['src/config/polyfills/perf_hooks.js'],
Expand Down
1 change: 0 additions & 1 deletion packages/node-native/rollup.npm.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ export default makeNPMConfigVariants(
dir: 'build',
// set exports to 'named' or 'auto' so that rollup doesn't warn
exports: 'named',
preserveModules: true,
},
},
}),
Expand Down
1 change: 0 additions & 1 deletion packages/node/rollup.npm.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export default [
output: {
// set exports to 'named' or 'auto' so that rollup doesn't warn
exports: 'named',
preserveModules: true,
},
},
}),
Expand Down
3 changes: 0 additions & 3 deletions packages/vercel-edge/rollup.npm.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ const baseConfig = makeBaseNPMConfig({
bundledBuiltins: ['perf_hooks', 'util'],
packageSpecificConfig: {
context: 'globalThis',
output: {
preserveModules: false,
},
plugins: [
replacePlugin(
{
Expand Down
Loading