-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(deps): bump @sentry/cli from 2.58.4 to 3.1.0 #18790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The
uploadSourceMapscalls inreact-routerandremixuseliveanduseArtifactBundleoptions that were removed in@sentry/cliv3.0.0, which will cause build-time errors.Severity: CRITICAL
🔍 Detailed Analysis
The upgrade to
@sentry/cliv3.1.0 introduces breaking changes to theuploadSourceMapsAPI. The code inpackages/react-routerandpackages/remixcontinues to pass thelive: 'rejectOnError'option, which is no longer supported. Additionally, the Remix package passesuseArtifactBundle, another option removed in v3.0.0. According to the library's release notes, these options were removed. Passing unsupported options to the new API will likely cause runtime errors during production builds when source maps are uploaded, preventing successful source map processing.💡 Suggested Fix
Remove the
liveanduseArtifactBundleproperties from the options object passed tosentry.releases.uploadSourceMapsinpackages/react-router/src/vite/buildEnd/handleOnBuildEnd.tsandpackages/remix/scripts/createRelease.js. The new API version handles this logic internally.🤖 Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID:
8495759