-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(tanstackstart-react): Trace server functions #18500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
andreiborza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, happy to go with this if you decide withSentry is the right api.
This PR adds tracing for tss server functions. To achieve this I added a new
wrapFetchWithSentrywrapper that can be used to instrument the tss server entry point:With this we get spans for server functions executed via
fetchcalls to the server. A limitation of this approach is that out-of-the-box this will only start a single span for the initial request made to the server. So for instance if a server function calls another server function, we will still only get a single span for the outer server function and users would need to wrap the inner call manually.Screenshot from my sample app with the current state:

Tests added:
Closes #18287