fix(vite): Ensure sentryVitePlugin always returns an array of plugins #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Jan 14, 2026
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Nice, thanks! Can you check if this is also an issue in the other plugins? Feel free to open follow-up PRs but ideally we can get rid of this bug everywhere
Member
Author
|
@Lms24 This is what I meant with "In other plugins this doesn't seem to be an issue, since we use any as the return type there." in the PR description, i.e. this seems to be the only plugin that has this bug so I think we are good |
Member
|
argh should have read the pr description ... should have read the pr description ... thanks Nico! |
Member
although ... we should change that probably 😬 |
Member
Author
|
we probably should in the next major, I'll open an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sentryVitePluginis typed to returnVitePlugin[]. The problem is that in case the factory we use returns an array with only a single entry,unpluginwill return a single plugin instead of an array. This can happen when the factory bails early and returns only thesentry-noop-plugin.In other plugins this doesn't seem to be an issue, since we use
anyas the return type there.