fix(gestures): Replace GestureDetectorCompat with lightweight detector to fix ANR#5138
Open
fix(gestures): Replace GestureDetectorCompat with lightweight detector to fix ANR#5138
Conversation
…stureDetector to fix ANR GestureDetectorCompat internally uses Handler.sendMessage/removeMessages which acquires a synchronized lock on the main thread MessageQueue, plus recordGestureClassification triggers IPC calls. This caused ANRs under load (SDK-CRASHES-JAVA-596, 175K+ occurrences). Replace with a minimal custom detector that only detects click, scroll, and fling without any Handler scheduling, MessageQueue contention, or IPC overhead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
🤖 This preview updates automatically when you update the PR. |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
...droid-core/src/main/java/io/sentry/android/core/internal/gestures/SentryGestureDetector.java
Show resolved
Hide resolved
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e59e22a | 329.74 ms | 383.31 ms | 53.57 ms |
| fc5ccaf | 270.49 ms | 363.90 ms | 93.41 ms |
| d15471f | 361.89 ms | 378.07 ms | 16.18 ms |
| d15471f | 322.58 ms | 396.08 ms | 73.50 ms |
| abfcc92 | 304.04 ms | 370.33 ms | 66.29 ms |
| 91bb874 | 310.68 ms | 359.24 ms | 48.56 ms |
| ab8a72d | 316.24 ms | 356.38 ms | 40.14 ms |
| d15471f | 286.65 ms | 314.68 ms | 28.03 ms |
| 6727e14 | 337.22 ms | 373.94 ms | 36.71 ms |
| f064536 | 329.00 ms | 395.62 ms | 66.62 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e59e22a | 1.58 MiB | 2.20 MiB | 635.34 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| 91bb874 | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| ab8a72d | 1.58 MiB | 2.12 MiB | 551.55 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 6727e14 | 1.58 MiB | 2.28 MiB | 718.64 KiB |
| f064536 | 1.58 MiB | 2.20 MiB | 633.90 KiB |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...droid-core/src/main/java/io/sentry/android/core/internal/gestures/SentryGestureDetector.java
Show resolved
Hide resolved
…velocity data Matches GestureDetector behavior: if consecutive ACTION_DOWN events arrive without an intervening ACTION_UP/ACTION_CANCEL, stale motion data could bleed into fling detection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
...ndroid-core/src/main/java/io/sentry/android/core/internal/gestures/SentryWindowCallback.java
Show resolved
Hide resolved
…check UserInteractionIntegration gated itself on GestureDetectorCompat being available via classloader check, but SentryGestureDetector only uses Android SDK classes. Remove the check so the integration works without androidx.core. Also remove the stale proguard -keep rule. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GestureDetectorCompatwith a custom lightweightSentryGestureDetectorinSentryWindowCallbackto fix ANR SDK-CRASHES-JAVA-596 (175K+ occurrences, 574 users)GestureDetectorCompatinternally usesHandler.sendMessage/removeMessageswhich acquires asynchronizedlock on the main thread'sMessageQueue, plusrecordGestureClassification()triggers IPC/binder calls — both cause contention under loadSentryGestureListeneruses), eliminating all Handler scheduling, MessageQueue lock contention, and IPC overheadTest plan
SentryGestureDetectorTestwith 7 test cases: tap, no-tap, scroll with deltas, fling, slow release, cancel cleanup, sequential gesture resetSentryWindowCallbackTest(4 tests) passesSentryGestureListenerTestsuite passes./gradlew :sentry-android-core:testDebugUnitTestpasses🤖 Generated with Claude Code