fix(transport): Handle HTTP 413 with actionable log and use send_error for HTTP errors#5115
fix(transport): Handle HTTP 413 with actionable log and use send_error for HTTP errors#5115
Conversation
…r for HTTP errors Log a specific, actionable error message when Relay returns HTTP 413 (Content Too Large) instead of the generic "Request failed" message. The message suggests reducing event/breadcrumb/attachment sizes and mentions the `SentryOptions.onOversizedEvent` callback. Also switch the client report discard reason for all HTTP 4xx/5xx errors (except 429) from `network_error` to `send_error`, matching the client reports spec and aligning with sentry-python and sentry-cocoa. Fixes GH-5050 Co-Authored-By: Claude <noreply@anthropic.com>
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Internal Changes 🔧Deps
🤖 This preview updates automatically when you update the PR. |
Co-Authored-By: Claude <noreply@anthropic.com>
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
sentry/src/main/java/io/sentry/transport/AsyncHttpTransport.java
Outdated
Show resolved
Hide resolved
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e59e22a | 329.74 ms | 383.31 ms | 53.57 ms |
| fc5ccaf | 270.49 ms | 363.90 ms | 93.41 ms |
| d15471f | 361.89 ms | 378.07 ms | 16.18 ms |
| d15471f | 322.58 ms | 396.08 ms | 73.50 ms |
| abfcc92 | 304.04 ms | 370.33 ms | 66.29 ms |
| 91bb874 | 310.68 ms | 359.24 ms | 48.56 ms |
| ab8a72d | 316.24 ms | 356.38 ms | 40.14 ms |
| d15471f | 286.65 ms | 314.68 ms | 28.03 ms |
| 6727e14 | 337.22 ms | 373.94 ms | 36.71 ms |
| f064536 | 329.00 ms | 395.62 ms | 66.62 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e59e22a | 1.58 MiB | 2.20 MiB | 635.34 KiB |
| fc5ccaf | 1.58 MiB | 2.13 MiB | 557.54 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| abfcc92 | 1.58 MiB | 2.13 MiB | 557.31 KiB |
| 91bb874 | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| ab8a72d | 1.58 MiB | 2.12 MiB | 551.55 KiB |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| 6727e14 | 1.58 MiB | 2.28 MiB | 718.64 KiB |
| f064536 | 1.58 MiB | 2.20 MiB | 633.90 KiB |
Previous results on branch: fix/handle-http-413
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 44bfea4 | 327.60 ms | 387.68 ms | 60.08 ms |
| 1ac1ac4 | 326.47 ms | 368.46 ms | 41.99 ms |
| e364cff | 328.61 ms | 384.38 ms | 55.77 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 44bfea4 | 1.58 MiB | 2.29 MiB | 721.11 KiB |
| 1ac1ac4 | 1.58 MiB | 2.29 MiB | 723.39 KiB |
| e364cff | 1.58 MiB | 2.29 MiB | 720.01 KiB |
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Switch client report discard reason for HTTP 4xx/5xx errors.
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
2 participants
Relay now returns HTTP 413 instead of HTTP 400 for oversized envelopes
(relay#5474). Previously
the SDK treated 413 like any other 4xx error with a generic log message,
giving users no indication of why their data was dropped.
This adds a specific, actionable error message when receiving HTTP 413,
suggesting users reduce the size of events, breadcrumbs, or attachments,
and pointing them to the
SentryOptions.onOversizedEventcallback.Also switches the client report discard reason for all HTTP 4xx/5xx errors
(except 429) from
network_errortosend_error, matching theclient reports spec and
aligning with sentry-python and sentry-cocoa.
network_erroris nowreserved for actual connectivity failures (IOException, transport gate
not connected).
Changes:
DiscardReason.java— AddedSEND_ERROR("send_error")HttpConnection.java— 413-specific log message inreadAndLog()AsyncHttpTransport.java— 413-specific log message +SEND_ERRORfor all HTTP errorsApacheHttpClientTransport.java— Same as aboveFixes #5050