You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent Lost-Event Handling for LogItem Envelopes
When a LogItem envelope item is lost but envelopeItem.getLogs() returns null (e.g., due to deserialization failure), no lost event is recorded. This is inconsistent with the Transaction handling (lines 91-103) which always records the transaction as lost even when getTransaction() returns null. The LogItem case should record at least 1 lost item when logs is null, similar to how other item types are handled in the else block (lines 111-113).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
When discarding logs we now report the number of bytes discarded in Client Reports.
💡 Motivation and Context
Since discarded log count is not shown in UI, we want to track discarded bytes too.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps