Add sentry-android-distribution module to release configuration#4791
Conversation
runningcode
requested review from
adinauer,
lcian,
markushi,
romtsn and
stefanosiano
as code owners
|
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
| } | ||
|
|
||
| if (!this.name.contains("sample") && !this.name.contains("integration-tests") && this.name != "sentry-system-test-support" && this.name != "sentry-test-support" && this.name != "sentry-android-distribution") { | ||
| if (!this.name.contains("sample") && !this.name.contains("integration-tests") && this.name != "sentry-system-test-support" && this.name != "sentry-test-support") { |
There was a problem hiding this comment.
Potential bug: Incomplete distribution module will crash when used
-
Description: Publishing the
sentry-android-distributionmodule exposes an incomplete implementation that throws aNotImplementedErrorwhen thecheckForUpdateBlockingmethod is called, which will cause a crash for users. -
Suggested fix: Complete the implementation of the
checkForUpdateBlockingmethod inDistributionIntegration.ktto handle update checks gracefully instead of throwing aNotImplementedError. Alternatively, if the module is not ready for public use, revert the change that publishes it to Maven Central.
severity: 3.0, confidence: 5.0
Did we get this right? 👍 / 👎 to inform future reviews.
| maven:io.sentry:sentry-apache-http-client-5: | ||
| maven:io.sentry:sentry-android: | ||
| maven:io.sentry:sentry-android-core: | ||
| maven:io.sentry:sentry-android-distribution: |
There was a problem hiding this comment.
I think for the first time it has to be manually added as described here: https://github.com/getsentry/sentry-release-registry#adding-new-sdks
After that we can merge the PR and it will be automatically published to the registry for future releases
There was a problem hiding this comment.
Oh. I was able to make a release already here: https://repo1.maven.org/maven2/io/sentry/sentry-android-distribution/8.24.0-alpha.1/
but I will do this!
romtsn
left a comment
romtsn
left a comment
There was a problem hiding this comment.
LGTM, considering we add the distribution module to the release registry manually first :)
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
runningcode
force-pushed
the
no/add-sentry-android-distribution-to-release-config
branch
from
0f7e4fd to
cea8556
Compare
runningcode
deleted the
no/add-sentry-android-distribution-to-release-config
branch
3 participants
Summary
This ensures the sentry-android-distribution module follows all requirements from
.cursor/rules/new_module.mdcand will be properly published to Maven Central.Solves EME-399
#skip-changelog
🤖 Generated with Claude Code